Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeds - Web images & video #81

Open
jinyuanqing opened this issue Jul 17, 2022 · 3 comments
Open

Embeds - Web images & video #81

jinyuanqing opened this issue Jul 17, 2022 · 3 comments

Comments

@jinyuanqing
Copy link

jinyuanqing commented Jul 17, 2022

Embeds - Default support for web images and video #81

VE Embeds - Move custom embed insertion code from demo page to the controller

VE Embeds - Resize image, see if we can reuse mobile options for web.


web and windows cannot show image.
web tips:!kIsWeb "Please provide EmbedBuilder for Web"
i can not find way

@adrian-moisa
Copy link
Collaborator

adrian-moisa commented Jul 18, 2022

Yes indeed, it's a known issue. One of the reasons I forked from Quill was the lack of default support for web images and videos. I don't have a clear explanation of why this is the maintainers of Quill did not add support. At some point I asked around but did not get any answer.

At the moment I'm busy fixing other more urgent issues in the code base. But support for images on the web is top prio. So expect this to be fixed within a month or so. I'll update here once ready. It's funny that I documented all these issues but forgot to list the images issue. It was such an obvious issue that I did not even bother to document. Thanks for opening the ticket.

Temporary notes:
Embeds - Restore inline images
{
"type": "image",
"imageUrl": "assets/posts/space-brains/international-standard-payload-rack-lockers.jpg",
"caption": "International Standard Payload Rack Lockers"
},

@adrian-moisa adrian-moisa self-assigned this Jul 18, 2022
@adrian-moisa adrian-moisa changed the title cannot show image [Web] Default support for web images and video Jul 18, 2022
@jinyuanqing
Copy link
Author

Thank you for your reply。

@adrian-moisa
Copy link
Collaborator

adrian-moisa commented Oct 26, 2022

We've been busy refactoring the existing code base and adding support for highlights and markers. In the meantime we got enough experience to figure out what to do for the web. We will fix this one soon. Apparently images already work just fine on the web. We just need to enable them for web (there's a piece of code that blocks images on the web). As for video, we have to add a web player.

unknown

Closed #21 Since it was a duplicate

References:

singerdmx/flutter-quill#887

@adrian-moisa adrian-moisa changed the title [Web] Default support for web images and video Embeds - Default support for web images and video Oct 26, 2022
@adrian-moisa adrian-moisa added MVP and removed Critical labels Nov 5, 2022
@adrian-moisa adrian-moisa removed their assignment Nov 5, 2022
@adrian-moisa adrian-moisa removed the 0.1 label Jan 23, 2024
@adrian-moisa adrian-moisa changed the title Embeds - Default support for web images and video Embeds - Web images & video Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants