Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6 compatibility #50

Open
97jaz opened this issue Apr 25, 2019 · 3 comments
Open

Rails 6 compatibility #50

97jaz opened this issue Apr 25, 2019 · 3 comments

Comments

@97jaz
Copy link

97jaz commented Apr 25, 2019

The render_anywhere gem (which this one depends on) doesn't work in Rails 6, since it mutates view_paths, which is no longer allowed.

It doesn't look like render_anywhere is actively maintained, so this is unlikely to be fixed there. On the upside, render_anywhere is a small gem.

@Marahin
Copy link
Contributor

Marahin commented May 10, 2019

@97jaz would you like to contribute towards bringing he Rails 6 support here?

@97jaz
Copy link
Author

97jaz commented May 10, 2019

@Marahin I started looking into it, but I don't think I have the bandwidth for this, especially if it needs to work for versions of Rails < 5. (My preferred way of getting this to work on Rails 5+ would be to use ActionController::Renderer, which, of course, would not work on earlier versions of Rails.)

@Marahin
Copy link
Contributor

Marahin commented May 20, 2019

That's an interesting approach and I'm fond of it. There hasn't been a decision made whether we want to continue supporting Rails 4, so I can't say anything here.

Either way help wanted definitely, so if anyone sees this post - you are more than welcome to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants