Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use href attribute for link with rel=modulepreload #16279

Merged
merged 1 commit into from
Mar 27, 2024
Merged

docs: use href attribute for link with rel=modulepreload #16279

merged 1 commit into from
Mar 27, 2024

Conversation

Laupetin
Copy link
Contributor

Description

Based on the HTML attribute reference documentation I have read, the <link> element with attribute rel=modulepreload should use the href attribute to specify the link instead of the src attribute.

The documentation I referenced for this information is:

Copy link

stackblitz bot commented Mar 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Mar 27, 2024
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sapphi-red sapphi-red merged commit c2d0b88 into vitejs:main Mar 27, 2024
10 checks passed
@Laupetin Laupetin deleted the docs/link-modulepreload-href branch March 27, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants