-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
feat(dev): support HTTP2 even if proxy feature is used #20869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Realized this should result in a slight api change - the first argument to |
http-proxy-3 does not support HTTP2 (sagemathinc/http-proxy-3#2), so we cannot do this yet. |
With the switch to http-proxy3 it should no longer be neccessary to fall back to http when using https and proxy at the same time
Clarified the note regarding TLS downgrade and certificate requirements.
http-proxy-3 now supports it (sagemathinc/http-proxy-3#33, #20925). |
@Corvince Would you remove the first parameter from |
Done. Let me know if there is anything else left to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me
commit: |
/ecosystem-ci run |
📝 Ran ecosystem CI on
✅ ladle, rakkas, astro, analogjs, marko, histoire, nuxt, one, sveltekit, vite-plugin-pwa, storybook, quasar, vite-plugin-cloudflare, vite-setup-catalogue, vite-plugin-svelte, vitest, vitepress, vite-plugin-rsc, vite-environment-examples, vite-plugin-vue, waku, vite-plugin-react, unocss, vike, vuepress |
Description
Fixes #4184. Previously using https and proxy server options did not work, since http-proxy didn't support https servers. With the recent switch to http-proxy3 this is no longer necessary and vite can support both options simultaneously, allowing to serve with http2.