Skip to content

Conversation

btea
Copy link
Contributor

@btea btea commented Oct 8, 2025

Description

When deleting temporary files, the corresponding temporary folders are not deleted. I think it would be better to delete them synchronously.

@sapphi-red sapphi-red added p2-edge-case Bug, but has workaround or limited in scope (priority) and removed p2-edge-case Bug, but has workaround or limited in scope (priority) labels Oct 14, 2025
@sapphi-red
Copy link
Member

I guess this would cause problem when there's two Vite instances and one instance calls the rm in this PR while the other instance called this mkdir and not called this await import.

@btea
Copy link
Contributor Author

btea commented Oct 14, 2025

I guess this would cause problem when there's two Vite instances and one instance calls the rm in this PR while the other instance called this mkdir and not called this await import.

👍 Good catch, there may be such a situation, maybe we should keep the code as it is. Even if there is an empty folder inside the node_modules folder, it will not have any effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants