Should buildStart run?

[wmertens]

When using rollup-plugin-node-externals with vitest, it crashes on this line.
The reason is that the include array wasn't initialized, which happens inside buildStart.

Is buildStart not supposed to run always?

[hi-ogawa]

I think this tends to happen when using Vite's createServer API but forgetting to run server.pluginContainer.buildStart. For example, vite-node has this readme:

vitest/packages/vite-node/README.md

Lines 87 to 95 in e4e939b

	// create vite server
	const server = await createServer({
	optimizeDeps: {
	// It's recommended to disable deps optimization
	disabled: true,
	},
	})
	// this is need to initialize the plugins
	await server.pluginContainer.buildStart({})

I don't think Vitest has any issues with this though. Can you provide a reproduction?

[hi-ogawa]

Just did a quick check and it looks working to me:

https://stackblitz.com/edit/vitest-dev-vitest-xsr7nz?file=vite.config.ts

Show screenshot

[wmertens]

apologies for not responding any more. I don't remember what the problem was, but indeed it wasn't buildStart and everything's ok now. Thanks!

[hi-ogawa]

Actually what you were seeing was probably right. Vitest had some issue with rollup-plugin-node-externals but it has been fixed sometime ago

• resolveId is called before buildStart with enforce: 'pre' #5616