Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: address name conventions in css #830

Closed
Hemanthghs opened this issue Oct 30, 2023 · 0 comments
Closed

refactor: address name conventions in css #830

Hemanthghs opened this issue Oct 30, 2023 · 0 comments

Comments

@Hemanthghs
Copy link
Collaborator

          Here are some initial comments
  • Don't include all styles in global.css. Only add CSS classes if they are used in multiple routes. otherwise, move them to the respective route's CSS.
  • Maintain consistency in CSS class names. Choose either camelCase or kebab-case and stick with it throughout the project.
  • Use descriptive and meaningful names for CSS classes. Avoid generic names like Feegrant1, Feegrant2, Header1 etc.
  • Stick to one naming convention for asset filenames. Choose either camelCase or kebab-case.

Originally posted by @aleem1314 in #805 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants