-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add/edit with pre-filled information requires for a "report no errors"-bounce #1220
Comments
Working test scenario:
|
@akelch let's talk about it again tomorrow in the ViUR meeting, because I think this bounce=silent or something is kind of crap, because bounce is a boolean and we actually wanted to get rid of it - if you look at it from the REST API perspective - rather than complicate it even more. I have now also built a simple test case (see above) where you can see this immediately. I think that the admin tool should be changed here after all, namely to send bounce=true in the initial case and simply ignore the errors, if any occur. Because you would have to install the bounce=silent anyway, and whether you do it this way or without complicating the core would be almost the same in the end, wouldn't it? |
Will be solved in the admin
|
Replaced/move into viur-framework/vi-admin#49 |
@phorward FYI, you can transfer issues to other repos |
This issue is a little bit hard to describe... in some cases, the admin calls a module's add or edit function within a context, which pre-fills some bones e.g. a RelationalBone with
mybone.dest.key=somekey
and should validate them.Depending on the skeleton, this might already lead in a creation or edit of the entry on initial load.
For this, there should be a special bounce-flag, which does the same as bounce=true, but without error reporting. So the input is parsed into the skeleton and returned as far as possible, but there should be no error reporting, this is done when "Save" is being hit.
Proposal:
bounce=true
should do the same as now, parse data, report errors, but don't save.bounce=silent
should do the same asbounce=true
, but without returning errors.The text was updated successfully, but these errors were encountered: