Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viur-prefix rule for currentDbAccessLog is inconvenient #35

Open
sveneberth opened this issue Sep 26, 2023 · 0 comments
Open

viur-prefix rule for currentDbAccessLog is inconvenient #35

sveneberth opened this issue Sep 26, 2023 · 0 comments
Labels
invalid This doesn't seem right

Comments

@sveneberth
Copy link
Member

sveneberth commented Sep 26, 2023 •
edited
Loading

This hardcoded condition is stupid. It is not explained anywhere and is simply made. Why should all viur-kinds be excluded? Why is this hardcoded here in the viur-datastore? Why not in the viur-core? Why is this not configurable? Why, why, why, … — because ViUR? 😕

viur-datastore/src/viur/datastore/query.py

Line 79 in 3f503cc

if not kind.startswith("viur") and not kwargs.get("_excludeFromAccessLog"):

@sveneberth sveneberth added invalid This doesn't seem right viur-meeting Issues to discuss in the next ViUR meeting labels Sep 26, 2023
@phorward phorward removed the viur-meeting Issues to discuss in the next ViUR meeting label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sveneberth @phorward