Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New post should be of kind 1 not kind 4549 now #52

Open
bigOconstant opened this issue Aug 24, 2023 · 3 comments
Open

New post should be of kind 1 not kind 4549 now #52

bigOconstant opened this issue Aug 24, 2023 · 3 comments

Comments

@bigOconstant
Copy link

Looking over the data zapddit creates I see new un approved post are currently of kind 4549 and the spec says to make it kind 1. Did you do that so retrieval would be more efficient? (I think it would) Or has the spec changed? I'm just trying to understand how things work here.

Should it be changed to type 1 and then inspect tags to see if it's a community post?

@vivganes
Copy link
Owner

Thanks for raising this issue, @bigOconstant 🙏 I agree that Kind 1 and not 4549 should be used as per the NIP.

The 4549 is the kind we decided on when I was collaborating with Stuart of satellite.earth. Relevant thread is here: nostr:nevent1qqsqsvwpvyjhlydwkrg02qm8phkrg6s6gw2yw9v22vvsqp6chv26sqcpz4mhxue69uhhyetvv9ujuerpd46hxtnfduhsyg8lylgpev09d76ctqpsd3a6w6asx7ljz8zm2u79de88pj59sa267qpsgqqqqqqsmchvcx

I realize that NIP has not called it out explicitly. I will initiate a discussion with Stuart and Jingles again this weekend and make the necessary changes.

@bigOconstant bigOconstant changed the title New post should be of kind 1 not king 4549 now New post should be of kind 1 not kind 4549 now Aug 25, 2023
@bigOconstant
Copy link
Author

nostr:nevent1qqsqsvwpvyjhlydwkrg02qm8phkrg6s6gw2yw9v22vvsqp6chv26sqcpz4mhxue69uhhyetvv9ujuerpd46hxtnfduhsyg8lylgpev09d76ctqpsd3a6w6asx7ljz8zm2u79de88pj59sa267qpsgqqqqqqsmchvcx

Not sure where I can view this. Searching that string in iris yields nothing.

I guess being kind 1 makes it show up in default feeds. Like any other note. But if you have it's own kind you can query less data and sort less data on the front end trying to find which have been approved and which have not been approved.

Is that thinking correct?

@vivganes
Copy link
Owner

Yes your line of thinking is correct.

You can see the note from this URL also :

https://snort.social/e/nevent1qqsqsvwpvyjhlydwkrg02qm8phkrg6s6gw2yw9v22vvsqp6chv26sqcpz4mhxue69uhhyetvv9ujuerpd46hxtnfduhsyg8lylgpev09d76ctqpsd3a6w6asx7ljz8zm2u79de88pj59sa267qpsgqqqqqqsmchvcx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants