-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New post should be of kind 1 not kind 4549 now #52
Comments
Thanks for raising this issue, @bigOconstant 🙏 I agree that Kind 1 and not 4549 should be used as per the NIP. The 4549 is the kind we decided on when I was collaborating with Stuart of satellite.earth. Relevant thread is here: nostr:nevent1qqsqsvwpvyjhlydwkrg02qm8phkrg6s6gw2yw9v22vvsqp6chv26sqcpz4mhxue69uhhyetvv9ujuerpd46hxtnfduhsyg8lylgpev09d76ctqpsd3a6w6asx7ljz8zm2u79de88pj59sa267qpsgqqqqqqsmchvcx I realize that NIP has not called it out explicitly. I will initiate a discussion with Stuart and Jingles again this weekend and make the necessary changes. |
Not sure where I can view this. Searching that string in iris yields nothing. I guess being kind 1 makes it show up in default feeds. Like any other note. But if you have it's own kind you can query less data and sort less data on the front end trying to find which have been approved and which have not been approved. Is that thinking correct? |
Yes your line of thinking is correct. You can see the note from this URL also : |
Looking over the data zapddit creates I see new un approved post are currently of kind 4549 and the spec says to make it kind 1. Did you do that so retrieval would be more efficient? (I think it would) Or has the spec changed? I'm just trying to understand how things work here.
Should it be changed to type 1 and then inspect tags to see if it's a community post?
The text was updated successfully, but these errors were encountered: