Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COM-908 Add test contact list #78

Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

COM-908 Add test contact list #78

wants to merge 49 commits into from

Conversation

juliawegmayr
Copy link
Contributor

@juliawegmayr juliawegmayr commented Aug 29, 2024 •
edited
Loading

  • Add changeset (if necessary)

  • Create a test contact list

  • Fix: if a contact is added to the main list, it was added to all lists without filters. Added a check for manuallyAssignedContacts.

  • Contacts added to a test list, don't need a double opt-in.

  • If a contact is added to the test list, it is possible to add it to the main list as well. Then a DOI is sent.

  • Test list is not displayed in the target group page.

@juliawegmayr juliawegmayr self-assigned this Aug 29, 2024
@auto-assign auto-assign bot requested a review from raphaelblum August 29, 2024 11:25
@juliawegmayr juliawegmayr marked this pull request as draft August 29, 2024 11:25
@juliawegmayr juliawegmayr removed the request for review from raphaelblum August 29, 2024 11:25
@juliawegmayr juliawegmayr marked this pull request as ready for review September 10, 2024 07:56
@juliawegmayr juliawegmayr changed the base branch from main to next September 17, 2024 10:21
@juliawegmayr juliawegmayr changed the base branch from next to main October 1, 2024 15:13
raphaelblum
raphaelblum previously approved these changes Oct 10, 2024
View reviewed changes
raphaelblum
raphaelblum previously approved these changes Oct 17, 2024
View reviewed changes
@RainbowBunchie
Copy link
Contributor

@juliawegmayr I just checked out the branch and the test list shows up in the target groups
Can you please take a look at this?
Screenshot 2024-10-25 at 12 55 17

@juliawegmayr
Copy link
Contributor Author

@juliawegmayr I just checked out the branch and the test list shows up in the target groups Can you please take a look at this? Screenshot 2024-10-25 at 12 55 17

Fixed here: 205b281

@RainbowBunchie
Copy link
Contributor

@juliawegmayr I just checked out the branch and the test list shows up in the target groups Can you please take a look at this? Screenshot 2024-10-25 at 12 55 17

Fixed here: 205b281

@juliawegmayr Shouldn't this work with the "normal" filters above? in "options.filter". Why do you need the custom filter logic here?

@juliawegmayr
Copy link
Contributor Author

@juliawegmayr I just checked out the branch and the test list shows up in the target groups Can you please take a look at this? Screenshot 2024-10-25 at 12 55 17

Fixed here: 205b281

@juliawegmayr Shouldn't this work with the "normal" filters above? in "options.filter". Why do you need the custom filter logic here?

True! I removed my changes again: ebfe653
Sorry for my missunderstandings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelblum raphaelblum raphaelblum left review comments

@RainbowBunchie RainbowBunchie Awaiting requested review from RainbowBunchie

Requested changes must be addressed to merge this pull request.

Assignees

@juliawegmayr juliawegmayr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliawegmayr @RainbowBunchie @raphaelblum