Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document which Units variants are valid for each property #19

Open
nicoburns opened this issue May 24, 2023 · 1 comment
Open

Document which Units variants are valid for each property #19

nicoburns opened this issue May 24, 2023 · 1 comment

Comments

@nicoburns
Copy link

I believe that not all variants of Units are valid for every style property which uses the Units type. It would be very helpful to have documentation stating which combinations and valid/invalid.

@geom3trik
Copy link
Collaborator

Agreed. I wonder if maybe new types should be used for those properties instead? The ones that come to mind are min/max constraints (where auto doesn't do anything), and border_ properties (where only pixels/percentage is used). In fact in vizia border is expressed with a LengthOrPercentage type which is then converted to Units during layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants