Merge pull request #537 from vizzuhq/fix-marker-behaviour-4

Remove hardly visible dimension axis guides between animation steps.
vizzuhq · May 31, 2024 · ecb9923 · ecb9923
2 parents 9e80091 + 0b443b6
commit ecb9923
Show file tree

Hide file tree

Showing 3 changed files with 67 additions and 67 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 
 ### Fixed
 
+- Remove hardly visible dimension axis guides between animation steps.
 - Do not calculate disabled markers to the color normalization. 
 - More precise TS type for transform matrix in event handlers. 
 - Add missing canvas change function in htmlcanvas plugin. 

diff --git a/src/chart/generator/guides.cpp b/src/chart/generator/guides.cpp
@@ -33,7 +33,6 @@ bool GuidesByAxis::operator==(const GuidesByAxis &other) const
 Guides::Guides(const Options &options)
 {
 	auto isCircle = options.geometry.get() == ShapeType::circle;
-	auto isLine = options.geometry.get() == ShapeType::line;
 	auto isHorizontal = options.isHorizontal();
 	const auto &channelX = options.getChannels().at(ChannelId::x);
 	const auto &channelY = options.getChannels().at(ChannelId::y);
@@ -53,8 +52,8 @@ Guides::Guides(const Options &options)
 	y.markerGuides = yOpt.markerGuides.getValue(
 	    isCircle && xIsMeasure && !isPolar);
 
-	x.axisGuides = xOpt.guides.getValue(isLine && xIsMeasure);
-	y.axisGuides = yOpt.guides.getValue(isLine && yIsMeasure);
+	x.axisGuides = xOpt.guides.getValue(false);
+	y.axisGuides = yOpt.guides.getValue(false);
 
 	x.interlacings = xOpt.interlacing.getValue(
 	    xIsMeasure && !isPolar && (!isHorizontal || !yIsMeasure));