From 82237e7954f617f4dadc199d768257fa68efe2d3 Mon Sep 17 00:00:00 2001 From: Jimmy Neville Date: Wed, 1 Nov 2023 12:18:51 -0400 Subject: [PATCH] feat: Allow 'both' option for uibannerposition (#14623) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix(ui): Drop ready from Completed container status (#14434) (#14629) Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 (#14641) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](https://github.com/go-git/go-git/compare/v5.7.0...v5.8.0) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix: webhook handler fails to refresh when alternate application namespaces are configured (#13976) * fix: Add failing test for webhooks in all namespaces This adds a failing test that properly exercises this functionality over all namespaces. The issue with the code that is under test is that it does not pass the namespace correctly to the patch of the application, resulting in the patch not taking place in the correct namespace Signed-off-by: Nikolas Skoufis * fix: queue webhook refresh for apps in all namespaces This passes the test in the previous commit, to ensure that webhooks correctly refresh applications across all namespaces. Signed-off-by: Nikolas Skoufis * fix: Use existing NamespacedName type Use the existing type instead of a custom type Signed-off-by: Nikolas Skoufis --------- Signed-off-by: Nikolas Skoufis Signed-off-by: Jimmy Neville * fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) (#14651) * ApplicationSet bug fix Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * Update applicationset/utils/utils_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(ui): The default pod group filter should be removed if fewer than 15 pods (#14590) Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville * feat(deep-links): sprig support (#14660) Signed-off-by: daftping <21245083+daftping@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore: Print in-cluster svr addr disabled warning when server starts (#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang * fix: mock Signed-off-by: Yuan Tang * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore: Upgrade semver to avoid cve (#14710) Signed-off-by: Yi Cai Signed-off-by: Jimmy Neville * feat: adding a autosync_enabled field to the argocd_app_info gauge (#14424) Signed-off-by: Gerardo Corea Signed-off-by: Jimmy Neville * fix(controller): log failed attempts to update operation state (#14273) * fix(controller): log failed attempts to update operation state Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new package name Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update controller/appcontroller_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(server): handle PATCH in http/s server (#2677) (#14530) Signed-off-by: mmerrill3 Signed-off-by: Jimmy Neville * fix: manifest generation error with null annotations (#14336) (#14680) * fix: manifest generation error with null annotations Signed-off-by: Alexandre Gaudreault * fix test Signed-off-by: Alexandre Gaudreault * fix unit tests Signed-off-by: Alexandre Gaudreault --------- Signed-off-by: Alexandre Gaudreault Signed-off-by: Jimmy Neville * Clean up repeated package import (#13889) Signed-off-by: Zechun Chen Signed-off-by: Jimmy Neville * fix(sso): Set redirectURI for gitea, google, oauth Dex connectors (#11237) Signed-off-by: ylxianzhe Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * feat(appset): Restrict scm provider urls (#14286) * 9353: Restrict scm provider urls Signed-off-by: gmuselli * 9353: Enforce restriction Signed-off-by: gmuselli * 9353: Fix after review Signed-off-by: gmuselli * 9353: Remove comment Signed-off-by: gmuselli * 9353: Fix units tests Signed-off-by: Geoffrey Muselli * 9353: Code review, update comment Signed-off-by: gmuselli * 9353: Code review, update comment 2 Signed-off-by: gmuselli * 9353: Remove doc issues Signed-off-by: gmuselli * 9353: Fix e2e Signed-off-by: gmuselli * 9353: Fix e2e goTemplate Signed-off-by: gmuselli * 9353: Fix e2e pullRequestGenerator Signed-off-by: gmuselli --------- Signed-off-by: gmuselli Signed-off-by: Geoffrey Muselli Signed-off-by: Jimmy Neville * chore(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 (#14744) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.305 to 1.44.309 (#14746) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.305...v1.44.309) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(ui): display valuesobject if set (#14257) * fix: display valuesobject if set With #11538 we now have the ability to set helm values as an object instead of a string, but we also need to be able to correctly display it in the UI if it is set. Signed-off-by: Blake Pettersson * fix: set valuesobject on save If `valuesObject` is present, set it to the value of `input.spec.source.helm.values` on save, as an unmarshaled json string. Signed-off-by: Blake Pettersson * fix: set `helm.values` to empty string on save If `valuesObject` exists, set `input.spec.source.helm.values` to an empty string once `valuesObject` has been unmarshalled from the values input. This is to prevent unnecessary duplication of the values. Signed-off-by: Blake Pettersson * chore: eslint Signed-off-by: Blake Pettersson * chore: eslint Signed-off-by: Blake Pettersson * fix: deep clone app This is so that we can conditionally set `source.helm.values` without inadvertently affecting other parts of the app. Only when the edit button is pressed do we toggle `source.helm.values`. Signed-off-by: Blake Pettersson * chore: eslint Signed-off-by: Blake Pettersson --------- Signed-off-by: Blake Pettersson Signed-off-by: Jimmy Neville * fix: OCI dependency url can't contain part of repository (#14699) Signed-off-by: Alexander Matyushentsev Signed-off-by: Jimmy Neville * docs: Add missing value (#14538) Signed-off-by: felix Signed-off-by: Jimmy Neville * [Bot] docs: Update Snyk reports (#14781) Signed-off-by: CI Co-authored-by: CI Signed-off-by: Jimmy Neville * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.309 to 1.44.312 (#14782) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.309...v1.44.312) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump github.com/xanzy/go-gitlab from 0.88.0 to 0.89.0 (#14784) Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0. - [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go) - [Commits](https://github.com/xanzy/go-gitlab/compare/v0.88.0...v0.89.0) --- updated-dependencies: - dependency-name: github.com/xanzy/go-gitlab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump github.com/casbin/casbin/v2 from 2.72.1 to 2.73.0 (#14783) Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0. - [Release notes](https://github.com/casbin/casbin/releases) - [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json) - [Commits](https://github.com/casbin/casbin/compare/v2.72.1...v2.73.0) --- updated-dependencies: - dependency-name: github.com/casbin/casbin/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore: add Autodesk to USERS.md (#14778) Signed-off-by: Dylan Page Signed-off-by: Jimmy Neville * chore: Add query-scoped cluster URL in Cluster Secret E2E tests (#14446) * Add query-scoped cluster URL in Cluster Secret E2E tests Signed-off-by: Jonathan West * Respond to review comments Signed-off-by: Jonathan West --------- Signed-off-by: Jonathan West Signed-off-by: Jimmy Neville * docs: Clarify that security policy covers last 3 versions (#14786) * docs: Clarify that security policy covers last 3 versions Signed-off-by: Kostis Kapelonis * Update SECURITY.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Kostis Kapelonis Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(controller): cache deadlock on delete and re-add cluster (#14780) Signed-off-by: Nathan Romriell Signed-off-by: Jimmy Neville * chore: make `helm template` errors less verbose (#14772) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * feat(deep-links): alias `application` as `apps` for consistency with notifications engine (#14761) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(ui): no hyphen for "create job" action + nice icon (#14776) (#14777) * chore(actions): space instead of hyphen in action name (#14776) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new field for backwards-compatibility Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * align icons for maximum synergy Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * delete unused function Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * revert unnecessary changes Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/upgrading/2.7-2.8.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix: Correct broken `forever` option in pod logs viewer. Fixes #14762 (#14763) Signed-off-by: Alex Collins Signed-off-by: Jimmy Neville * docs: Update application.yaml (#14742) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * docs: add ignoreDifferences name and namespace fields (#14741) * Update application.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/application.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump library/node from 20.4.0 to 20.5.0 (#14664) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump library/node from 20.4.0 to 20.5.0 in /ui-test (#14662) Bumps library/node from 20.4.0 to 20.5.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * docs: Update Controlling-Resource-Modification.md (#14751) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795) * Add nil check for notifications_catalog triggers Signed-off-by: Trung * Use correct nil check Signed-off-by: Trung * Add missing catalog generation to makefile Signed-off-by: Trung * Revert changes to update-manifests.sh Signed-off-by: Trung --------- Signed-off-by: Trung Signed-off-by: Jimmy Neville * fix: ManagedResources API should not return diff for hooks (#14816) Signed-off-by: Alexander Matyushentsev Signed-off-by: Jimmy Neville * docs: Change Generator docs for List Generator to note any key/value pairs can be used (#14825) This is no longer limited to cluster/url value pairs. Signed-off-by: JesseBot Signed-off-by: Jimmy Neville * chore: improve app destination docstrings (#14836) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * feat: Adding kubelogin capability to argocd-k8s-auth (#9460) (#10700) Signed-off-by: mmerrill3 Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore: Add header support for proxy extension requests (#14800) * chore: add server URL in the header of proxy extensions Signed-off-by: Leonardo Luz Almeida * feat: add header support for proxy extension requests Signed-off-by: Leonardo Luz Almeida * Address review comments Signed-off-by: Leonardo Luz Almeida * address review comments Signed-off-by: Leonardo Luz Almeida * Address review comments Signed-off-by: Leonardo Luz Almeida * Address review comments Signed-off-by: Leonardo Luz Almeida --------- Signed-off-by: Leonardo Luz Almeida Signed-off-by: Jimmy Neville * docs: use consistent password in plugin generator examples (#14837) * docs: use consistent password in plugin generator examples The example secret with the token is using `strong-password`, but the later examples use `string-password`. This updates all of the examples to use `strong-password`. Signed-off-by: Nicholas Morey * docs: update another-secret example to include `strong-password` Consistent with above example of client token in argocd-secret Signed-off-by: Nicholas Morey --------- Signed-off-by: Nicholas Morey Signed-off-by: Jimmy Neville * chore: give context to error logs #10592 (#14851) * chore: give context to error logs Signed-off-by: ashinsabu3 * Update reposerver/repository/repository.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: ashinsabu3 Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore: add more tests in proxy extension headers (#14842) Signed-off-by: Leonardo Luz Almeida Signed-off-by: Jimmy Neville * chore: revert #12255 (#14858) This reverts commit c651bd8de551c85fc897c997c1976d6777259921. Due to the imminent release of 2.8, this needs to be rolled back since the proposed fix in #14210 cannot make it in time. Signed-off-by: Blake Pettersson Signed-off-by: Jimmy Neville * fix: Repo URL link for unsupported sources links to https:///null/path/to/chart (#14861) * Fix #14860 Fix #14860 Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> * Update USERS.md Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> --------- Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix: correct discrepancies in generated swagger file (#14813) Signed-off-by: Alexander Matyushentsev Signed-off-by: Jimmy Neville * chore: wrap ComparisonError messages (#14886) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(ui): Fixes health icon positioning (#14708) (#14852) * fix: Fixes health icon positioning #14708 Signed-off-by: ashinsabu3 * fix: Fixes alignment of app health application status panel #14708 Signed-off-by: ashinsabu3 * fix: Added line height to App Status to fix its positioning #14708 Signed-off-by: ashinsabu3 --------- Signed-off-by: ashinsabu3 Signed-off-by: Jimmy Neville * chore: fix non-deterministic test (#14905) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537) * fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registry Signed-off-by: xashr * Add test coverage for SemVer tags in TestGetTagsFromUrl Signed-off-by: xashr --------- Signed-off-by: xashr Signed-off-by: Jimmy Neville * fix(appset): typo in ARGOCD_APPLICATIONSET_CONTROLLER_ALLOWED_SCM_PROVIDERS (#14902) (#14913) Signed-off-by: gmuselli Signed-off-by: Jimmy Neville * feat: provide short revision in ARGOCD_APP_REVISION_SHORT env variable (#14926) Signed-off-by: Alexander Matyushentsev Signed-off-by: Jimmy Neville * chore(deps): bump github.com/aws/aws-sdk-go from 1.44.312 to 1.44.317 (#14925) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.312 to 1.44.317. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.312...v1.44.317) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#14922) Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0. - [Commits](https://github.com/golang/oauth2/compare/v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * docs: Update Generators-Git.md (#14921) Remove a misleading symbol from the pattern for the path.Match function. The pipe symbol doesn't have any special meaning. Signed-off-by: German Lashevich Signed-off-by: Jimmy Neville * docs: Update helm.md - add missing syntax highlighting for YAML and Dockerfile blocks (#14911) Signed-off-by: JesseBot Signed-off-by: Jimmy Neville * fix(ui): COPY JSON for ArgoCD version should include trailing newline (#5117) (#14917) Signed-off-by: Vipin M S Signed-off-by: Jimmy Neville * [Bot] docs: Update Snyk reports (#14919) Signed-off-by: CI Co-authored-by: CI Signed-off-by: Jimmy Neville * chore: give context to error logs (#10592) (#14915) * chore: wrap error objects to include context Signed-off-by: Vipin M S * chore: wrap error objects to include context Signed-off-by: Vipin M S * chore: wrap error objects to include context Signed-off-by: Vipin M S * chore: wrap error objects to include context Signed-off-by: Vipin M S * Update applicationset/controllers/applicationset_controller.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Vipin M S Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * feat(appset): Add SCM Provider option for Gitlab generator to filter shared projects from subgroups projects (#14831) * added option to disable gitlab to fetch shared project from a subgroup Signed-off-by: Prune * Correct gitlab SCM provider mock test Signed-off-by: Prune * updated test to validate shared-groups Signed-off-by: Prune * reworked shared project tests Signed-off-by: Prune * added subgroups only test Signed-off-by: Prune --------- Signed-off-by: Prune Signed-off-by: Jimmy Neville * fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955) * fix: send sigterm to cmp commands before sigkill to allow for potential cleanup Signed-off-by: Ashin Sabu * fix: unit test for runCommand in cmpserver to test cleanup modified Signed-off-by: Ashin Sabu * fix: change unit test for plugin/runCommand to avoid bad trap along with lint fix Signed-off-by: Ashin Sabu --------- Signed-off-by: Ashin Sabu Signed-off-by: Jimmy Neville * docs: Feature bounty proposal (Experimental) (#14234) * Create bounty proposal Signed-off-by: Dan Garfield * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield * Update docs/proposals/feature-bounties.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Dan Garfield * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield * Update docs/proposals/feature-bounties.md Signed-off-by: Dan Garfield --------- Signed-off-by: Dan Garfield Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(actions): check if CronWorkflow has labels in create-workflow action (#14962) (#14974) Signed-off-by: Mickaël Canévet Signed-off-by: Jimmy Neville * chore: add Jellysmack in USERS.md (#14975) Signed-off-by: Mickaël Canévet Signed-off-by: Jimmy Neville * chore(deps): bump actions/setup-go from 4.0.1 to 4.1.0 (#14970) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](https://github.com/actions/setup-go/compare/fac708d6674e30b6ba41289acaab6d4b75aa0753...93397bea11091df50f3d7e59dc26a7711a8bcfbe) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * docs: Adding native OCI support proposal (#13516) Signed-off-by: Andrew Block Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore: space in 'Argo CD' (#14987) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * feat: Add Support for AzureDevops Webhooks (#14969) * feat: Add Support for AzureDevops Webhooks Signed-off-by: Alexander Matyushentsev * document azure devops webhook configuration Signed-off-by: Alexander Matyushentsev --------- Signed-off-by: Alexander Matyushentsev Signed-off-by: Jimmy Neville * fix: api server fails to call dex with istio (#14995) Signed-off-by: Alexander Matyushentsev Signed-off-by: Jimmy Neville * fix(ui): Update default and max count for maxCookieNumber (#14979) * Update default and max count for maxCookieNumber Signed-off-by: zvlb Signed-off-by: Jimmy Neville * fix: correct the swagger ui link to support --rootpath (#14845) Signed-off-by: Kevin Yue Signed-off-by: Jimmy Neville * chore(deps): upgrade nhooyr.io/websocket dependency (#15000) Upgrade from 1.8.6 to 1.8.7 due to high security issue Was solved in dependency with https://github.com/nhooyr/websocket/pull/291 Signed-off-by: jmeridth Signed-off-by: Jimmy Neville * chore: upgrade to go 1.21 (#14992) Signed-off-by: Robin Lieb Signed-off-by: Jimmy Neville * chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#14996) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](https://github.com/goreleaser/goreleaser-action/compare/336e29918d653399e599bfca99fadc1d7ffbc9f7...3fa32b8bb5620a2c1afe798654bbad59f9da4906) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix: bump ubuntu base image (#15020) (#15021) Latest version of the ubuntu image addresses CVE-2023-38408. https://ubuntu.com/security/notices/USN-6242-1 https://github.com/docker-library/repo-info/blob/master/repos/ubuntu/remote/22.04.md resolves #15020 Signed-off-by: Mason Cole Signed-off-by: Jimmy Neville * chore: give context to errors (#10592) (#15022) * chore: give context to errors Signed-off-by: Vipin M S * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/settings/settings.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Update util/tls/tls.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Vipin M S Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore: give context to errors (#15019) * chore: give context to error logs in reposerver Signed-off-by: Ashin Sabu * chore: give context to errors in applicationset Signed-off-by: Ashin Sabu * chore: give context to errors(tweaks in error messages) Signed-off-by: Ashin Sabu * chore: give context to errors(fix unit test) Signed-off-by: Ashin Sabu --------- Signed-off-by: Ashin Sabu Signed-off-by: Jimmy Neville * chore: add Carrefour Group to USERS.md (#15039) Signed-off-by: Zadkiel Aharonian Signed-off-by: Jimmy Neville * fix(health): spec.executor.instances is Optional, Support a flexible number of executors (#11877) Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator. Signed-off-by: Philipp Dallig Signed-off-by: Jimmy Neville * [Bot] docs: Update Snyk reports (#15031) Signed-off-by: CI Co-authored-by: CI Signed-off-by: Jimmy Neville * fix(reposerver): loosen source not permitted helm errors (#14210) * fix: loosen source not permitted helm errors With #12255, we check if a source is first permitted before running `helm template`. This works a bit too well, since this may break previously working manifests. If an `AppProject` has a set of `sourceRepos` which are more restrictive than `*`, and it also has Helm public dependencies (repos with credentials would not work with 2.7x due to the fact they get filtered out before ending up on the repo server). Whereas before this would work, this currently fails on `HEAD` but not in `2.7x`. What we instead do here is that we only run this check if the chart failed to download - if it does then we run a check to see if the repo is in the allowed repos list. If the repo is not in the allowed repos list, we return the same error as in #12555, otherwise we bubble up the error. Should fix #13833. Signed-off-by: Blake Pettersson * fix: check for 401 unauthorized in error The regex check works fine for OCI artifacts, but the flow is slightly different for standard Helm charts (specifically when running `helm repo add`). To get around that, we also check the error for `401 Unauthorized`. Signed-off-by: Blake Pettersson * fix: loosen string check Signed-off-by: Blake Pettersson * Revert "chore: revert #12255 (#14858)" This reverts commit c8ae5bc3e79fa985632861f75669c07523f5ded6. Signed-off-by: Blake Pettersson * wip Signed-off-by: Blake Pettersson * wip Signed-off-by: Blake Pettersson * chore: reword test to reduce confusion Signed-off-by: Blake Pettersson --------- Signed-off-by: Blake Pettersson Signed-off-by: Jimmy Neville * fix(appset): Fix helm valuesObject with ApplicationSet (#14912) (#14920) Signed-off-by: Geoffrey Muselli Signed-off-by: Jimmy Neville * feat(cli): support apply out of sync flag only (#14624) * feat: support apply out of sync flag only Signed-off-by: pashakostohrys * update engine version Signed-off-by: pashakostohrys * update gitops engine version Signed-off-by: pashakostohrys * add cli option Signed-off-by: pashakostohrys * feat: verify apply out of sync flag Signed-off-by: pashakostohrys * redundant comment Signed-off-by: pashakostohrys * improve test logic Signed-off-by: pashakostohrys * change command description and do codegen Signed-off-by: pashakostohrys --------- Signed-off-by: pashakostohrys Signed-off-by: Jimmy Neville * docs(github): comment out notational pieces of PR template (#14888) - the DCO and FAQ sentences are not filled out during PRs and are purely notational - comment them out with HTML comments, as is common practice - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1 - copied this practice from other repos I maintain and from other repos before that - these comments are still visible to the PR author, just not visible when rendered, keeping the PR more concise Signed-off-by: Anton Gilgur Signed-off-by: Jimmy Neville * chore(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#15053) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](https://github.com/golangci/golangci-lint-action/compare/639cd343e1d3b897ff35927a75193d57cfcba299...3a919529898de77ec3da873e3063ca4b10e7f5cc) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (#15054) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/e33196f7422957bea03ed53f6fbb155025ffc7b8...bea5baf987ba7aa777a8a0b4ace377a21c45c381) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * docs: Update bank vaults link to point to the new org (#15069) Bank-Vaults recently migrated to a new organization. The old repository is archived. Signed-off-by: Anton Lindholm Signed-off-by: Jimmy Neville * chore: improve error logs (#10592) (#15059) * chore: improve error logs Signed-off-by: AvhiMaz * chore: Changes made according to the reviewer Signed-off-by: AvhiMaz * chore: Chnages according to the reviewerI" Signed-off-by: AvhiMaz * Update cmpserver/apiclient/plugin.pb.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: AvhiMaz Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * docs: Update link to KubeCon China 2021 talk in README.md (#14887) Signed-off-by: Yuan (Terry) Tang Signed-off-by: Jimmy Neville * docs: document permitOnlyProjectScopedClusters field (#15076) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * docs: kubectl to synchronize argocd apps (#14881) We can use kubectl to synchronize argocd applications the same way we can use the argocd cli or ui, however there's no documentation. This PR adds documentation for kubectl. Signed-off-by: Jordi Grant Esteve Signed-off-by: Jimmy Neville * docs: fix typo (#15083) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * feat: add timeout for update cluster info (#14511) * chore: simplified parsing of startup parameters Signed-off-by: yyzxw <1020938856@qq.com> * feat: add timeout for update cluster info Signed-off-by: yyzxw <1020938856@qq.com> --------- Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Jimmy Neville * fix: requeue ApplicationSet if there are validation errors (#14429) Signed-off-by: Chetan Banavikalmutt Signed-off-by: Jimmy Neville * docs: fix link for `argocd-repo-creds.yaml` sample (#15091) Signed-off-by: SHIMADA Kento Signed-off-by: Jimmy Neville * chore: wrap error objects to include context (#10592) (#15055) * chore: wrap error objects to include context (#10592) Signed-off-by: Pawank06 * chore: resolved common_test.go file as per reviewer's feedback Signed-off-by: Pawank06 * chore:changes in ulits.go Signed-off-by: Pawank06 * chore: resolving utils_test.go file Signed-off-by: Pawank06 --------- Signed-off-by: Pawank06 Signed-off-by: B Pawan Kumar Signed-off-by: Jimmy Neville * fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065) Signed-off-by: Dylan Slavin Signed-off-by: Jimmy Neville * docs: add docs for various annotations and labels (#14020) * docs: add docs for various annotations Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more info Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more docs Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(appset): bitbucket server scm provider EOF on empty repo (#14411) * fix bitbucket server scm provider EOF on empty repo default branch check Signed-off-by: Jedrzej Kotkowski * add unit test for bitbucketServer empty repo Signed-off-by: Jedrzej Kotkowski * check for EOF explicitly Signed-off-by: Jedrzej Kotkowski --------- Signed-off-by: Jedrzej Kotkowski Signed-off-by: Jimmy Neville * chore: update confusing variable name (#15106) Signed-off-by: jmcshane Signed-off-by: Jimmy Neville * docs(progressive syncs): specify which ConfigMap to use (#15119) Signed-off-by: Gaël Jourdan-Weil Signed-off-by: Jimmy Neville * feat(appset): added topic filter for Gitlab SCM (#14965) * added topic (tag) filter for Gitlab SCM Signed-off-by: Prune * corrected few comments Signed-off-by: Prune * removed latest tag references Signed-off-by: Prune --------- Signed-off-by: Prune Signed-off-by: Jimmy Neville * chore: Add kustomization.yaml for server app RBAC (#15124) This change adds a `kustomization.yaml` file for the example RBAC role/rolebinding for argocd server applications. This makes it easier to include them as resources in another `kustomization.yaml`. Instead of including ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrole.yaml - https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrolebinding.yaml ``` the user can now instead include ```yaml apiVersion: kustomize.config.k8s.io/v1beta1 kind: Kustomization resources: - github.com/argoproj/argo-cd/examples/k8s-rbac/argocd-server-applications?ref=v2.8.0 ``` This change was performed by running: ```console kustomize create kustomize edit add resource argocd-server-rbac-clusterrole.yaml kustomize edit add resource argocd-server-rbac-clusterrolebinding.yaml ``` Signed-off-by: Andreas Lindhé Signed-off-by: Jimmy Neville * docs: ✏️ fix typo on configmap name for private certs (#9596) Signed-off-by: Gaël Jourdan-Weil Signed-off-by: Jimmy Neville * Merge pull request from GHSA-c8xw-vjgf-94hr Signed-off-by: pashakostohrys Signed-off-by: Jimmy Neville * fix(ui): code lint (#15150) Signed-off-by: ebuildy Signed-off-by: Jimmy Neville * fix: windows build (#15154) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * feat: run refresh from UI in parallel (#15138) Signed-off-by: Lukas Wöhrl Signed-off-by: Jimmy Neville * fix(cli): add support for components with non-default names (#10200) (#14605) * fix(cli): add support for components with non-default names (#10200) Co-Authored-By: maheshbaliga Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: maheshbaliga Signed-off-by: Jimmy Neville * fix: Updated docs about using a slash in ignoreDifferences (#15144) Signed-off-by: Christian Hernandez Signed-off-by: Jimmy Neville * fix: stop creating new otel interceptor to avoid memory leak (#15174) Signed-off-by: Alexander Matyushentsev Signed-off-by: Jimmy Neville * chore: add example jq path expression (#15130) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * docs: document sourceNamespaces field (#15195) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(appset): Matrix Generator Override not Working for Booleans (#14498) (#14573) * Fix AppSet matrix generator parameter override Signed-off-by: Alexander Bellhäuser * Add test case for parameter override fix Signed-off-by: Alexander Bellhäuser --------- Signed-off-by: Alexander Bellhäuser Signed-off-by: Jimmy Neville * docs: remove unnecessary version number (#15198) We have versioned docs now, no need for this. Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(ui): switch podgroup notification to tooltip message (#14821) * improve pod grouping ux Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> fix: update log view on container select Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui): improve pod grouping ux Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui):update the pod grouping messages to tooltip Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix(ui):update the pod grouping messages to tooltip Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix: GroupNodes notification Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> * fix: GroupNodes notification Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> --------- Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore: add upsider to USERS.md (#15228) Signed-off-by: Vlad Fratila Signed-off-by: Jimmy Neville * docs: clarify argocd-repo-server repo-cache-expiration HA use case (#15239) Signed-off-by: phanama Signed-off-by: Jimmy Neville * chore: better logs for jq expression errors (#15226) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(ui): Helm chart empty maintainers blow up Argo UI (#15225) Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro Signed-off-by: Jimmy Neville * chore: add Kvist to USERS.md (#15240) Signed-off-by: Fredrik A. Madsen-Malmo Signed-off-by: Jimmy Neville * docs: improve doc on labels parameter on scmProvider generator (#15255) Signed-off-by: Jedrzej Kotkowski Signed-off-by: Jimmy Neville * docs: Update ApplicationSet docs (#15269) Signed-off-by: David Muckle Signed-off-by: Jimmy Neville * feat: support extra attributes for opentelemetry (#15071) Signed-off-by: penglongli Signed-off-by: Jimmy Neville * docs: Add Twilio Segment to USERS.md (#15267) Thank you to the Argo community! Signed-off-by: Prasad Katti Co-authored-by: jannfis Signed-off-by: Jimmy Neville * fix: make WatchResourceTree use namespaced cache key (#15258) * fix: make WatchResourceTree use namespaced application cache key Signed-off-by: Torbjørn Fjørtoft * chore: add PGS to USERS.md Signed-off-by: Torbjørn Fjørtoft --------- Signed-off-by: Torbjørn Fjørtoft Signed-off-by: Jimmy Neville * chore: remove duplicate function (#15123) Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Jimmy Neville * fix: Cache control 404 asset requests (#15327) * backfill cache control header tests for ui assets Signed-off-by: Scott Windsor * Set cache-control header non-cache for assets not found Signed-off-by: Scott Windsor * fix golang-cilint warning Signed-off-by: Scott Windsor --------- Signed-off-by: Scott Windsor Signed-off-by: Jimmy Neville * docs: Fixes a markdown typo in USERS.md (#15362) This removes the whitespace between the link text and the link URL. Signed-off-by: Prasad Katti Signed-off-by: Jimmy Neville * feat: upgrade notification engine (#15359) * Update notifications-engine dependencies Signed-off-by: Mike Splain * Update docs Signed-off-by: Mike Splain --------- Signed-off-by: Mike Splain Co-authored-by: pasha-codefresh Signed-off-by: Jimmy Neville * feat: add Dott to users (#15370) Signed-off-by: Jake Burn Signed-off-by: Jimmy Neville * fix(notifications-catalog): Add nil check for on-deployed trigger (#15363) Signed-off-by: Fs02 Co-authored-by: pasha-codefresh Signed-off-by: Jimmy Neville * feat: auto respect rbac for discovery/sync (#14381) feat: auto respect rbac for discovery/sync (#14381) Signed-off-by: Soumya Ghosh Dastidar Signed-off-by: Jimmy Neville * feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159) Signed-off-by: Brad West Signed-off-by: Jimmy Neville * fix(appset): Revert applicationset-name labels (#15324) * fix(15282) Revert applicationset-name labels Signed-off-by: gmuselli * fix(15282) fix unit test Signed-off-by: gmuselli --------- Signed-off-by: gmuselli Signed-off-by: Jimmy Neville * chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366) Bumps library/node from 20.4.0 to 20.6.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * Merge pull request from GHSA-g687-f2gx-6wm8 * feat: use untar with limiter Signed-off-by: pashakostohrys * feat: use untar with limiter Signed-off-by: pashakostohrys --------- Signed-off-by: pashakostohrys Signed-off-by: Jimmy Neville * Merge pull request from GHSA-fwr2-64vr-xv9m * fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotation Signed-off-by: Alexander Matyushentsev * fix: failing unit test Signed-off-by: iam-veeramalla --------- Signed-off-by: Alexander Matyushentsev Signed-off-by: iam-veeramalla Co-authored-by: iam-veeramalla Signed-off-by: Jimmy Neville * chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364) Bumps library/node from 20.5.0 to 20.6.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix: handle annotations for resources with ':' in the name (#15101) (#15380) * fix: handle annotations for resources with ':' in the name Signed-off-by: Oreon Lothamer * fix: switch to using splitN for handling annotation splitting Signed-off-by: Oreon Lothamer * fix: check len(parts) !=3 Signed-off-by: Oreon Lothamer * Retrigger CI pipeline Signed-off-by: Oreon Lothamer --------- Signed-off-by: Oreon Lothamer Signed-off-by: Jimmy Neville * docs: Improve RBAC documentation (#15430) * Improve staging-db project name This change renames the project to distinguish it from the role. Signed-off-by: Andreas Lindhé * Rename db-staging role to singular form Role names should be singular ("User x has the role admin" as opposed to "User x has the role admins"). Signed-off-by: Andreas Lindhé * Remove trailing newlines Signed-off-by: Andreas Lindhé * Consistently mark `AppProject` as code Signed-off-by: Andreas Lindhé * Replace ```shell with ```console in suitable places Signed-off-by: Andreas Lindhé * Use consistent style for unordered list https://github.com/DavidAnson/markdownlint/blob/main/doc/md004.md Signed-off-by: Andreas Lindhé * Use consistent emphasis style https://github.com/DavidAnson/markdownlint/blob/main/doc/md049.md Signed-off-by: Andreas Lindhé * Fix incorrect description of the staging-db example Signed-off-by: Andreas Lindhé --------- Signed-off-by: Andreas Lindhé Signed-off-by: Jimmy Neville * fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378) * fix(appsets): gotemplate can cause panic from nil deference Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * fix(appsets): gotemplate can cause panic from nil dereference Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> --------- Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore: Fix flaky cluster test (#15433) Signed-off-by: Jimmy Neville * Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407) Signed-off-by: Cezar Sa Espinola Signed-off-by: Jimmy Neville * feat: added shorthand flags for follow and conatainre in app logs (#15400) * feat: added shorthand flags for follow and conatainre in app logs Signed-off-by: ashu * doc: re-generated cli docs Signed-off-by: ashu --------- Signed-off-by: ashu Co-authored-by: jannfis Signed-off-by: Jimmy Neville * [Bot] docs: Update Snyk reports (#15437) Signed-off-by: CI Co-authored-by: CI Co-authored-by: jannfis Signed-off-by: Jimmy Neville * fix: Better enforcement of application namespace restrictions (#15431) * fix: Better enforce application namespace restrictions Signed-off-by: jannfis * Only call ValidateDestination when allowed Signed-off-by: jannfis --------- Signed-off-by: jannfis Signed-off-by: Jimmy Neville * docs: fix bullets (#15446) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350) * fix: failed to add cluster when the cluster server address is ipv6 (#8204) Signed-off-by: huyinhou * fix: failed to add cluster when the cluster server address is ipv6 (#8204) Signed-off-by: huyinhou * remove unused import Signed-off-by: huyinhou * fix: lowercase URI secret name; abbreviated IPv6 address Signed-off-by: huyinhou --------- Signed-off-by: huyinhou Signed-off-by: Jimmy Neville * feat: Enable haproxy metrics through helm Chart (#15459) Signed-off-by: Mathias Petermann Signed-off-by: Jimmy Neville * Stop appending :443 to the server address when using grpc-web (#15435) Signed-off-by: David Marby Co-authored-by: jannfis Signed-off-by: Jimmy Neville * feat: appset preserve labels and global preserve fields (#15445) * feat: appset preserve labels and global preserve fields Signed-off-by: Soumya Ghosh Dastidar * feat: appset preserve labels and global preserve fields Signed-off-by: Soumya Ghosh Dastidar * docs: updated docs Signed-off-by: Soumya Ghosh Dastidar * docs: updated docs Signed-off-by: Soumya Ghosh Dastidar --------- Signed-off-by: Soumya Ghosh Dastidar Signed-off-by: Jimmy Neville * fix: Gitlab scm_provider - don't create transport from scratch (#15424) (#15425) * fix : don't create transport from scratch, clone it instead Signed-off-by: Antoine Jouve * feat: clone http.transport for gitea and gitlab providers Signed-off-by: Antoine Jouve * chore: properly format gitea providers with gofmt Signed-off-by: Antoine Jouve --------- Signed-off-by: Antoine Jouve Signed-off-by: Jimmy Neville * chore: add Factorial to USERS.md (#15473) Signed-off-by: Alejandro López Sánchez Signed-off-by: Jimmy Neville * Fix incorrect wording in ApplicationSet git generator docs (#15374) Signed-off-by: Liam Wyllie Signed-off-by: Jimmy Neville * fix: Allow retrieving badges in other namespaces (#15468) Signed-off-by: jannfis Signed-off-by: Jimmy Neville * chore(deps): bump docker/setup-buildx-action from 2.9.1 to 3.0.0 (#15476) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.9.1 to 3.0.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](https://github.com/docker/setup-buildx-action/compare/4c0219f9ac95b02789c1075625400b2acbff50b1...f95db51fddba0c2d1ec667646a06c2ce06100226) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump library/node from 20.6.0 to 20.6.1 in /test/container (#15451) Bumps library/node from 20.6.0 to 20.6.1. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump library/node from 20.6.0 to 20.6.1 in /ui-test (#15452) Bumps library/node from 20.6.0 to 20.6.1. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump gitpod/workspace-full from `d578722` to `511cecd` (#15453) Bumps gitpod/workspace-full from `d578722` to `511cecd`. --- updated-dependencies: - dependency-name: gitpod/workspace-full dependency-type: direct:production ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump argo-ui from `13cea62` to `002d01b` in /ui (#15440) Bumps [argo-ui](https://github.com/argoproj/argo-ui) from `13cea62` to `002d01b`. - [Release notes](https://github.com/argoproj/argo-ui/releases) - [Commits](https://github.com/argoproj/argo-ui/compare/13cea62a4a0e4a14a2dd6908490e1e907709aa86...002d01b18e8aaf4b21307a3b87341ab05230483f) --- updated-dependencies: - dependency-name: argo-ui dependency-type: direct:production ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump library/golang in /test/remote (#15419) Bumps library/golang from `970907c` to `62e5883`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump library/golang from `970907c` to `62e5883` (#15415) Bumps library/golang from `970907c` to `62e5883`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(controller): make managed namespaces more 'prune-proof' (#13999) * fix: make managed namespaces more 'prune-proof' In the cases where someone would want to set resource tracking on a managed namespace, or if someone would want to migrate from having a namespace in Git to using `managedNamespaceMetadata`, we need to take steps to ensure that the namespace does not get pruned. In order to do that, we add the live namespace to the list of `targetObjs` (so that it's considered a part of the source even though it's not). Finally, we need to also ensure that the managed namespace is not considered `OutOfSync` (due to the same reason as above). This is a subset of #11350, the main difference being that this commit does not set resource tracking on its own, but can be opted into if people choose to do so. Signed-off-by: Blake Pettersson * refactor: extract managed namespace check Signed-off-by: Blake Pettersson --------- Signed-off-by: Blake Pettersson Signed-off-by: Jimmy Neville * fix: extends CR to allow cronjob/workflow triggers (#15300) Signed-off-by: Marcelo Moreira de Mello Co-authored-by: Nicholas Morey Signed-off-by: Jimmy Neville * chore(deps): bump library/node from 20.5.0 to 20.6.1 (#15454) Bumps library/node from 20.5.0 to 20.6.1. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jannfis Signed-off-by: Jimmy Neville * chore(deps): bump github.com/cyphar/filepath-securejoin (#15401) Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.2.3 to 0.2.4. - [Release notes](https://github.com/cyphar/filepath-securejoin/releases) - [Commits](https://github.com/cyphar/filepath-securejoin/compare/v0.2.3...v0.2.4) --- updated-dependencies: - dependency-name: github.com/cyphar/filepath-securejoin dependency-type: direct:production ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * (docs) Add clarification on migration for CMP plugins (#15405) * Add clarification on migration for CMP plugins Signed-off-by: Dan Garfield * Fix table Signed-off-by: Dan Garfield * Add warning on blank manifests for #15340 Signed-off-by: Dan Garfield --------- Signed-off-by: Dan Garfield Signed-off-by: Jimmy Neville * chore(deps): bump sigstore/cosign-installer from 3.1.1 to 3.1.2 (#15330) Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](https://github.com/sigstore/cosign-installer/compare/6e04d228eb30da1757ee4e1dd75a0ec73a653e06...11086d25041f77fe8fe7b9ea4e48e3b9192b8f19) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump github.com/xanzy/go-gitlab from 0.89.0 to 0.91.1 (#15331) Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.89.0 to 0.91.1. - [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go) - [Commits](https://github.com/xanzy/go-gitlab/compare/v0.89.0...v0.91.1) --- updated-dependencies: - dependency-name: github.com/xanzy/go-gitlab dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * docs: Add KPMG to users (#15323) Signed-off-by: Ansuman Swain Co-authored-by: jannfis Signed-off-by: Jimmy Neville * Fix broken links for post selectors, fix ordering of args for dig example (#15346) Signed-off-by: David Muckle Signed-off-by: Jimmy Neville * chore(deps): bump library/golang in /test/container (#15502) Bumps library/golang from 1.21.0 to 1.21.1. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump github.com/casbin/casbin/v2 from 2.73.0 to 2.77.2 (#15501) Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.73.0 to 2.77.2. - [Release notes](https://github.com/casbin/casbin/releases) - [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json) - [Commits](https://github.com/casbin/casbin/compare/v2.73.0...v2.77.2) --- updated-dependencies: - dependency-name: github.com/casbin/casbin/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump actions/upload-artifact from 3.1.2 to 3.1.3 (#15497) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/0b7f8abb1508181956e8e162db84b466c27e18ce...a8a3f3ad30e3422c9c7b888a15615d19a852ae32) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jannfis Signed-off-by: Jimmy Neville * fix(cli): fix header in resource-overrides list-actions output (#15375) Signed-off-by: Maxime Brunet Signed-off-by: Jimmy Neville * chore: adding tests for apiclient package: clientset tests (#15193) Signed-off-by: zhaque44 Signed-off-by: Jimmy Neville * fix: Applicationset upsert for any namespaces (#15520) * fix: Applicationset upsert for any namespaces PR implements a small change to the argocd command adding the AppsetNamespace for the existing Appset check. Signed-off-by: Harm Matthias Harms * Retrigger CI pipeline Signed-off-by: Harm Matthias Harms * Retrigger CI pipeline Signed-off-by: Harm Matthias Harms --------- Signed-off-by: Harm Matthias Harms Signed-off-by: Jimmy Neville * chore: update ordering of support steps (#15508) Signed-off-by: Kurt King Signed-off-by: Jimmy Neville * feat: add option in output flag for app get and app resources cli command for tree view(#13370) (#15386) * tree view feature for app get cli comand Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * including application details Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * testcase included for printTreeView Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * removed the unnecessary variables Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * Adding changes to the documentation Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * change in the argocd doc Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * included tee_test.go Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * tree view changes for app get and app resources Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * go.mod and go.sum by running go mod tidy Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * changes after review Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * changes after review Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> --------- Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump github.com/go-playground/webhooks/v6 (#15516) Bumps [github.com/go-playground/webhooks/v6](https://github.com/go-playground/webhooks) from 6.2.1-0.20230808162451-10570b0a59e8 to 6.3.0. - [Release notes](https://github.com/go-playground/webhooks/releases) - [Commits](https://github.com/go-playground/webhooks/commits/v6.3.0) --- updated-dependencies: - dependency-name: github.com/go-playground/webhooks/v6 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix: ApplicationSet deletes Application status (#15514) * fix: ApplicationSet deletes Application status Signed-off-by: Alexander Matyushentsev * apply reviewer notes Signed-off-by: Alexander Matyushentsev --------- Signed-off-by: Alexander Matyushentsev Signed-off-by: Jimmy Neville * docs: Update Application Set Webhook Instructions (#13764, #11532) (#15527) * Update Generators-Pull-Request.md Add note to clarify that the ApplicationSet controller requires its own Ingress resource. This seems to be a common issue for Argo CD users. Signed-off-by: Kurt Madel * Update Generators-Git.md Updating note to match webhook note on pr generator. Signed-off-by: Kurt Madel --------- Signed-off-by: Kurt Madel Signed-off-by: Jimmy Neville * chore: Add 4data to users (#15531) Signed-off-by: LStuker Signed-off-by: Jimmy Neville * docs: fix kubectl apply in apps-in-any-namespace doc (#15197) There's a kustomization.yaml file in that directory, so we should apply it with `-k`. Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * docs: Fix docs for destinations in AppProjects (#15153) (#15182) Signed-off-by: Andreas Lindhé Signed-off-by: Jimmy Neville * chore(deps): bump github.com/ktrysmt/go-bitbucket from 0.9.63 to 0.9.67 (#15500) Bumps [github.com/ktrysmt/go-bitbucket](https://github.com/ktrysmt/go-bitbucket) from 0.9.63 to 0.9.67. - [Release notes](https://github.com/ktrysmt/go-bitbucket/releases) - [Commits](https://github.com/ktrysmt/go-bitbucket/compare/v0.9.63...v0.9.67) --- updated-dependencies: - dependency-name: github.com/ktrysmt/go-bitbucket dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jannfis Signed-off-by: Jimmy Neville * chore(deps): bump goreleaser/goreleaser-action from 4.4.0 to 5.0.0 (#15496) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.4.0 to 5.0.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](https://github.com/goreleaser/goreleaser-action/compare/3fa32b8bb5620a2c1afe798654bbad59f9da4906...7ec5c2b0c6cdda6e8bbb49444bc797dd33d74dd8) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * [Bot] docs: Update Snyk reports (#15532) Signed-off-by: CI Co-authored-by: CI Signed-off-by: Jimmy Neville * chore(deps): bump actions/checkout from 3.5.3 to 4.0.0 (#15348) * chore(deps): bump actions/checkout from 3.5.3 to 4.0.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 4.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/c85c95e3d7251135ab7dc9ce3241c5835cc595a9...3df4ab11eba7bda6032a0b82a6bb43b11571feac) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] * Apply suggestions from code review Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * feat(ui): Add button for wrapping lines in pod logs viewer (#15506) * Add back wrap log line button Signed-off-by: Yi Cai * Fixed lint issue Signed-off-by: Yi Cai * Updated icon and location of Wrap Lines btn Signed-off-by: Yi Cai * Fixed lint issue Signed-off-by: Yi Cai * Put back pre tag and Ansi component Signed-off-by: Yi Cai --------- Signed-off-by: Yi Cai Signed-off-by: Jimmy Neville * chore: add CODEOWNERS (#14693) * chore: add CODEOWNERS Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new owners Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * use teams Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * restore old owners file Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix: reflect expected integers in swagger doc (#13046) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump oras.land/oras-go/v2 from 2.2.1 to 2.3.0 (#15549) Bumps [oras.land/oras-go/v2](https://github.com/oras-project/oras-go) from 2.2.1 to 2.3.0. - [Release notes](https://github.com/oras-project/oras-go/releases) - [Commits](https://github.com/oras-project/oras-go/compare/v2.2.1...v2.3.0) --- updated-dependencies: - dependency-name: oras.land/oras-go/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump github.com/antonmedv/expr from 1.12.7 to 1.15.2 (#15548) Bumps [github.com/antonmedv/expr](https://github.com/antonmedv/expr) from 1.12.7 to 1.15.2. - [Release notes](https://github.com/antonmedv/expr/releases) - [Commits](https://github.com/antonmedv/expr/compare/v1.12.7...v1.15.2) --- updated-dependencies: - dependency-name: github.com/antonmedv/expr dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(repo-server): avoid fetching commit sha for multisource applications (#15037) (#15067) * Rebase Signed-off-by: ozlevka-work Signed-off-by: Lev * Remove test file Signed-off-by: ozlevka-work Signed-off-by: Lev * Go linter fmt Signed-off-by: ozlevka-work Signed-off-by: Lev * Additional linter fmt Signed-off-by: ozlevka-work Signed-off-by: Lev Signed-off-by: Lev * Add unit test for changes Signed-off-by: Lev Signed-off-by: Lev * Update reposerver/repository/repository.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Lev Ozeryansky Signed-off-by: Lev * Trigger CI Signed-off-by: Lev --------- Signed-off-by: Lev Signed-off-by: Lev Signed-off-by: Lev Ozeryansky Co-authored-by: Lev Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * doc: adds vals-operator to secrets list (#11795) Vals-Operator can also be used for managing secrets in Kubernetes. Signed-off-by: Sergio Rua <58211930+digiserg@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump actions/cache from 3.3.1 to 3.3.2 (#15552) Bumps [actions/cache](https://github.com/actions/cache) from 3.3.1 to 3.3.2. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8...704facf57e6136b1bc63b828d79edcd491f0ee84) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jannfis Signed-off-by: Jimmy Neville * docs: better command reference titles (#15567) (#15568) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump library/node from 20.6.1 to 20.7.0 in /ui-test (#15583) Bumps library/node from 20.6.1 to 20.7.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump library/node from 20.6.1 to 20.7.0 in /test/container (#15585) Bumps library/node from 20.6.1 to 20.7.0. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh Signed-off-by: Jimmy Neville * docs: Add documentation on how to specify shard number for a cluster in "high availibility" doc (#5348) (#13258) Signed-off-by: Sridhar Nandigam Signed-off-by: Jimmy Neville * docs: 'action' RBAC example for Kind without group (#15589) Signed-off-by: Jimmy Neville * chore: add gdsoumya to reviewers (#15596) Signed-off-by: gdsoumya <44349253+gdsoumya@users.noreply.github.com> Signed-off-by: Jimmy Neville * feat: added patch_ms and setop_ms timings to reconciliation logs (#15595) * feat: added patch_ms to reconciliation logs Signed-off-by: Soumya Ghosh Dastidar * feat: added patch_ms and setop_ms timings to logs Signed-off-by: Soumya Ghosh Dastidar --------- Signed-off-by: Soumya Ghosh Dastidar Signed-off-by: Jimmy Neville * chore(action): minor lua changes (#15580) * chore(action): add newlines at eof Signed-off-by: Josh Soref * chore(action): fix whitespace indentation Signed-off-by: Josh Soref * chore(action): use local annotations Signed-off-by: Josh Soref --------- Signed-off-by: Josh Soref Signed-off-by: Jimmy Neville * chore(deps): bump library/golang from `cffaba7` to `2270a40` (#15615) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * feat(extensions): Automatically apply extension configs without restarting API-Server (#15574) * feat: auto configure extensions Signed-off-by: Leonardo Luz Almeida * feat: auto-reload extension configs without restarting api-server Signed-off-by: Leonardo Luz Almeida * clean unused gorilla mux Signed-off-by: Leonardo Luz Almeida * update docs Signed-off-by: Leonardo Luz Almeida * Address review comments Signed-off-by: Leonardo Luz Almeida * Add more test cases Signed-off-by: Leonardo Luz Almeida * refactoring to reduce unnecessary function Signed-off-by: Leonardo Luz Almeida * Add log Signed-off-by: Leonardo Luz Almeida * fix bugs found during manual tests Signed-off-by: Leonardo Luz Almeida --------- Signed-off-by: Leonardo Luz Almeida Signed-off-by: Jimmy Neville * Update the supported version policy in Operator Manual Installation doc (#15619) The supported version policy mentioned in the operator manual installation document diverges from the official policy that is mentioned in the security policy and the release cadence. This change brings the version policy in line by referring the readers to the release and cadence documentation to check the specified policy. Signed-off-by: Muhammad Mooneeb Hussain Signed-off-by: Jimmy Neville * doc: resource tracking custom label configuration (#15587) Signed-off-by: Timoses Signed-off-by: Jimmy Neville * feat(cli): tree option in output flag for app sync, app wait and app rollback for tree view (#15572) * app sync and app wait tree view changes Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * documentation changes Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * included the json,yaml and wide formats and removed the value assignment to the flag Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * Reoved extra spaces Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * removed extra spaces Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * refactored the code Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * better log statements Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> --------- Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Jimmy Neville * feat: dynamic rebalancing of clusters across shards (#15036) * Migrate Application Controller from Statefulset to Deployment Signed-off-by: ishitasequeira * Add sharding deployment logic Signed-off-by: ishitasequeira * Update sharding logic and add comments Signed-off-by: ishitasequeira * Add heartbeat as an environment variable Signed-off-by: ishitasequeira * Add retry logic, heartbeat timeout environment variable Signed-off-by: ishitasequeira * use the logic of pre-specified shard number on application controller pod Signed-off-by: ishitasequeira * fix manifests Signed-off-by: ishitasequeira * fix lint and e2e tests Signed-off-by: ishitasequeira * comment out failing e2e test Signed-off-by: ishitasequeira * increase readiness probe interval period Signed-off-by: ishitasequeira * "comment out readiness probe to see if e2e tests succeed" Signed-off-by: ishitasequeira * revert commented readiness probe Signed-off-by: ishitasequeira * revert commented test case Signed-off-by: ishitasequeira * read environment variable for application controller deployment name Signed-off-by: ishitasequeira * Add nil check on replica count for deployment of application controller Signed-off-by: ishitasequeira * Address comments Signed-off-by: ishitasequeira * Add Informer, Update documentation, add unit tests Signed-off-by: ishitasequeira * update godoc Signed-off-by: ishitasequeira * remove unwanted code and logs Signed-off-by: ishitasequeira * Add more documentation Signed-off-by: ishitasequeira * revert ApplicationController manifest to StatefulSet Signed-off-by: ishitasequeira * reverting updated docs Signed-off-by: ishitasequeira * Add documentation for the new dynamic distribution feature Signed-off-by: ishitasequeira * update documentation Signed-off-by: ishitasequeira * Add an overlay for application controller deployment and update documentation Signed-off-by: ishitasequeira * fix nit Signed-off-by: ishitasequeira * Marking the feature as alpha Signed-off-by: ishitasequeira * Add feature status link Signed-off-by: ishitasequeira * revert go,mod changes Signed-off-by: ishitasequeira * update docs to avoid focusing on StatefulSet/Deployment (#26) * update docs to avoid focusing on StatefulSet/Deployment Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * minor update to the doc Signed-off-by: ishitasequeira --------- Signed-off-by: ishitasequeira Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump node version (#15616) * chore(deps): bump node version Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix version Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * update lockfile Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * feat(appset): add Support for AzureDevops Webhooks (#15047) Signed-off-by: Robin Lieb Signed-off-by: Jimmy Neville * fix(cli): get latest app state before printing tree (#15639) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(deps): bump actions/setup-node from 3.8.0 to 3.8.1 (#15108) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.8.0 to 3.8.1. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/bea5baf987ba7aa777a8a0b4ace377a21c45c381...5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Co-authored-by: pasha-codefresh Signed-off-by: Jimmy Neville * feat(kustomize): add patches field (#5114) (#14648) Signed-off-by: Jimmy Neville * feat(health): Implement AnsibleJob CRD health checks (#14483) Signed-off-by: Mike Ng Signed-off-by: Jimmy Neville * feat(health): add PushSecret health status and force-sync action (#14375) * feat(health): add `PushSecret` health status Signed-off-by: Alexandre Gaudreault * add status healthy Signed-off-by: Alexandre Gaudreault * Push action Signed-off-by: Alexandre Gaudreault * fix test Signed-off-by: Alexandre Gaudreault --------- Signed-off-by: Alexandre Gaudreault Signed-off-by: Jimmy Neville * fix(kustomize): no concurrent processing if Kustomize patches are used (#15654) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * feat(appset): ignoreApplicationDifferences (#9101) (#14743) * feat(appset): ignoreDifferences (#9101) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * better error messages Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * do better Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * docs Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more tests, update docs Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * e2e test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * expect auto-added fields Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * correct label Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * better Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * remove line that was reverted Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update docs/operator-manual/applicationset.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * remove line that mysteriously causes applicationset/utils unit tests to fail Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * login to fix test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * maybe this will work, who knows Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * burn it all down Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * works on my machine Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(applicationset): cannot validate inherited project permissions (#9298) (#15026) * fix(applicationset): cannot validate inherited project permissions Signed-off-by: Alexandre Gaudreault * update tests to reflect behavior Signed-off-by: Alexandre Gaudreault --------- Signed-off-by: Alexandre Gaudreault Signed-off-by: Jimmy Neville * chore(deps): bump semver from 5.7.1 to 5.7.2 in /ui-test (#14457) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](https://github.com/npm/node-semver/compare/v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville * chore(ci): free up disk space (#15674) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix: add a not found check for application controller deployment (#15678) Signed-off-by: ishitasequeira Signed-off-by: Jimmy Neville * [fix] sidebar style (#15652) Signed-off-by: ymktmk Co-authored-by: Blake Pettersson Signed-off-by: Jimmy Neville * fix(ci): free up disk space (#15683) * fix(ci): free up disk space Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update .github/workflows/image-reuse.yaml Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update .github/workflows/image-reuse.yaml Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(ci): do not fail fast on e2e test failures (#15694) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(ci): misplaced config option (#15698) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville * fix(applicationset): git generator ignores empty files (#15661) Signed-off-by: Alexandre Gaudreault Signed-off-by: Jimmy Neville * fix(appset): don't emit k8s events for unchanged apps, log at debug (#15659) (#15660) * fix(appset): don't emit k8s events for unchanged application events and move that scenario to debug logging level Signed-off-by: Eric Blackburn * Retrigger CI pipeline Signed-off-by: Eric Blackburn * Retrigger CI pipeline Signed-off-by: Eric Blackburn --------- Signed-off-by: Eric Blackburn Co-authored-by: Alexander Matyushentsev Signed-off-by: Jimmy Neville * feat(ci): retry individual e2e tests (#15696) Signed-off-by: Jimmy Neville * docs: Maintaining Uniformity In Documentation Writing Style (#15713) In the Projects section there are two words 'what' and 'where' are written in italic(in the first two sentences) but in the third sentence 'what' is written in normal text. So i changed the two words written in italic to normal text to maintain the uniformity of writing style of documentation. See this issue in the Projects section : "https://argo-cd.readthedocs.io/en/stable/user-guide/projects/" Signed-off-by: PranitRout07 <102309095+PranitRout07@users.noreply.github.com> Signed-off-by: Jimmy Neville * docs: add dynamic cluster distribution doc in the menu (#15716) Signed-off-by: Jimmy Neville * Converted italic text to normal text (#15692) To see the issue , go to this link "https://argo-cd.readthedocs.io/en/stable/operator-manual/app-any-namespace/" In Prerequisites section ,the word 'not' is unnecessarily written in italic. It should be written in normal text to maintain the uniformity. Signed-off-by: PranitRout07 <102309095+PranitRout07@users.noreply.github.com> Co-authored-by: Dan Garfield Signed-off-by: Jimmy Neville * fix(action): populate all fields of Job from CronJob (#15259) (#15727) Signed-off-by: sergey.ladutko Co-authored-by: sergey.ladutko Signed-off-by: Jimmy Neville * fix(application-controller): Fix panic error when trying to scale application controller shards (#15725) * Added error checking to determine if application controller deployment is found or not Signed-off-by: Anand Francis Joseph * Fixed the informer to list deployments in namespace scope Signed-off-by: Anand Francis Joseph * Fixed readiness check probe for application controller when running as deployment Signed-off-by: Anand Francis Joseph --------- Signed-off-by: Anand Francis Joseph Signed-off-by: Jimmy Neville * docs: move self-signed certs gitlab scm docs (#15720) Signed-off-by: Jimmy Neville * fix: only enable dynamic cluster sharding feature explicitly (#15734) * fix: only enable dynamic cluster sharding feature explicitly Signed-off-by: Remington Breeze --------- Signed-off-by: Remington Breeze Signed-off-by: Jimmy Neville * Fixed Custom Link Text not Hyperlinked (#15747) Visit this link to see the issue : https://argo-cd.readthedocs.io/en/stable/developer-guide/ci/#public-cd Signed-off-by: PranitRout07 <102309095+PranitRout07@users.noreply.github.com> Signed-off-by: Jimmy Neville * Update docs Signed-off-by: Jimmy Neville --------- Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Jimmy Neville Signed-off-by: dependabot[bot] Signed-off-by: Nikolas Skoufis Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: daftping <21245083+daftping@users.noreply.github.com> Signed-off-by: Yuan Tang Signed-off-by: Yi Cai Signed-off-by: Gerardo Corea Signed-off-by: mmerrill3 Signed-off-by: Alexandre Gaudreault Signed-off-by: Zechun Chen Signed-off-by: ylxianzhe Signed-off-by: gmuselli Signed-off-by: Geoffrey Muselli Signed-off-by: Blake Pettersson Signed-off-by: Alexander Matyushentsev Signed-off-by: felix Signed-off-by: CI Signed-off-by: Dylan Page Signed-off-by: Jonathan West Signed-off-by: Kostis Kapelonis Signed-off-by: Nathan Romriell Signed-off-by: Alex Collins Signed-off-by: Trung Signed-off-by: JesseBot Signed-off-by: Leonardo Luz Almeida Signed-off-by: Nicholas Morey Signed-off-by: ashinsabu3 Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> Signed-off-by: xashr Signed-off-by: German Lashevich Signed-off-by: Vipin M S Signed-off-by: Prune Signed-off-by: Ashin Sabu Signed-off-by: Dan Garfield Signed-off-by: Mickaël Canévet Signed-off-by: Andrew Block Signed-off-by: zvlb Signed-off-by: Kevin Yue Signed-off-by: jmeridth Signed-off-by: Robin Lieb Signed-off-by: Mason Cole Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> Signed-off-by: Zadkiel Aharonian Signed-off-by: Philipp Dallig Signed-off-by: pashakostohrys Signed-off-by: Anton Gilgur Signed-off-by: Anton Lindholm Signed-off-by: AvhiMaz Signed-off-by: Yuan (Terry) Tang Signed-off-by: Jordi Grant Esteve Signed-off-by: yyzxw <1020938856@qq.com> Signed-off-by: Chetan Banavikalmutt Signed-off-by: SHIMADA Kento Signed-off-by: Pawank06 Signed-off-by: B Pawan Kumar Signed-off-by: Dylan Slavin Signed-off-by: Jedrzej Kotkowski Signed-off-by: jmcshane Signed-off-by: Gaël Jourdan-Weil Signed-off-by: Andreas Lindhé Signed-off-by: Gaël Jourdan-Weil Signed-off-by: ebuildy Signed-off-by: Lukas Wöhrl Signed-off-by: Christian Hernandez Signed-off-by: Alexander Bellhäuser Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Vlad Fratila Signed-off-by: phanama Signed-off-by: Carlos Castro carlos.castro@jumo.world Signed-off-by: Carlos Castro Signed-off-by: Fredrik A. Madsen-Malmo Signed-off-by: David Muckle Signed-off-by: penglongli Signed-off-by: Prasad Katti Signed-off-by: Torbjørn Fjørtoft Signed-off-by: Scott Windsor Signed-off-by: Mike Splain Signed-off-by: Jake Burn Signed-off-by: Fs02 Signed-off-by: Soumya Ghosh Dastidar Signed-off-by: Brad West Signed-off-by: iam-veeramalla Signed-off-by: Oreon Lothamer Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> Signed-off-by: Cezar Sa Espinola Signed-off-by: ashu Signed-off-by: jannfis Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: huyinhou Signed-off-by: Mathias Petermann Signed-off-by: David Marby Signed-off-by: Antoine Jouve Signed-off-by: Alejandro López Sánchez Signed-off-by: Liam Wyllie Signed-off-by: Marcelo Moreira de Mello Signed-off-by: Ansuman Swain Signed-off-by: Maxime Brunet Signed-off-by: zhaque44 Signed-off-by: Harm Matthias Harms Signed-off-by: Kurt King Signed-off-by: Kurt Madel Signed-off-by: LStuker Signed-off-by: Lev Signed-off-by: Lev Signed-off-by: Lev Ozeryansky Signed-off-by: Sergio Rua <58211930+digiserg@users.noreply.github.com> Signed-off-by: Sridhar Nandigam Signed-off-by: gdsoumya <44349253+gdsoumya@users.noreply.github.com> Signed-off-by: Josh Soref Signed-off-by: Muhammad Mooneeb Hussain Signed-off-by: Timoses Signed-off-by: ishitasequeira Signed-off-by: Mike Ng Signed-off-by: ymktmk Signed-off-by: Eric Blackburn Signed-off-by: PranitRout07 <102309095+PranitRout07@users.noreply.github.com> Signed-off-by: sergey.ladutko Signed-off-by: Anand Francis Joseph Signed-off-by: Remington Breeze Co-authored-by: schakrad <58915923+schakrad@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nik Skoufis Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: asingh <11219262+ashutosh16@users.noreply.github.com> Co-authored-by: daftping <21245083+daftping@users.noreply.github.com> Co-authored-by: Yuan Tang Co-authored-by: Yi Cai Co-authored-by: Gerardo Corea Co-authored-by: Michael Merrill Co-authored-by: Alexandre Gaudreault Co-authored-by: Fish-pro Co-authored-by: XianzheTM Co-authored-by: Geoffrey MUSELLI Co-authored-by: Blake Pettersson Co-authored-by: Alexander Matyushentsev Co-authored-by: Felix Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: CI Co-authored-by: Dylan Page Co-authored-by: Jonathan West Co-authored-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> Co-authored-by: Nathan Romriell Co-authored-by: Alex Collins Co-authored-by: Hoang Quoc Trung Co-authored-by: JesseBot Co-authored-by: Leonardo Luz Almeida Co-authored-by: Nicholas Morey Co-authored-by: Ashin Sabu <139749674+ashinsabu3@users.noreply.github.com> Co-authored-by: Talia Stocks <928827+taliastocks@users.noreply.github.com> Co-authored-by: xashr <103113861+xashr@users.noreply.github.com> Co-authored-by: German Lashevich Co-authored-by: Vipin M S <40431065+vipinachar@users.noreply.github.com> Co-authored-by: Prune Sebastien THOMAS Co-authored-by: Dan Garfield Co-authored-by: Mickaël Canévet Co-authored-by: Andrew Block Co-authored-by: Vladimir <31961982+zvlb@users.noreply.github.com> Co-authored-by: Kevin Yue Co-authored-by: Jason Meridth Co-authored-by: Robin Lieb Co-authored-by: Mason Cole <117116981+bt-macole@users.noreply.github.com> Co-authored-by: Zadkiel Aharonian Co-authored-by: Philipp Dallig Co-authored-by: pasha-codefresh Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Co-authored-by: Anton Lindholm Co-authored-by: Avhi Mazumder <102310138+AvhiMaz@users.noreply.github.com> Co-authored-by: selaci Co-authored-by: yyzxw <34639446+yyzxw@users.noreply.github.com> Co-authored-by: Chetan Banavikalmutt Co-authored-by: SHIMADA Kento Co-authored-by: B Pawan Kumar Co-authored-by: Dylan Slavin Co-authored-by: jjsiv <96917147+jjsiv@users.noreply.github.com> Co-authored-by: James McShane Co-authored-by: Gaël Jourdan-Weil Co-authored-by: Andreas Lindhé Co-authored-by: Gaël Jourdan-Weil Co-authored-by: Thomas Decaux Co-authored-by: Lukas Wöhrl Co-authored-by: maheshbaliga Co-authored-by: Christian Hernandez Co-authored-by: Alexander Bellhäuser Co-authored-by: Vlad Fratila Co-authored-by: Yudi A Phanama <11147376+phanama@users.noreply.github.com> Co-authored-by: Carlos Castro Co-authored-by: Fredrik A. Madsen-Malmo Co-authored-by: David Muckle Co-authored-by: Pelen Co-authored-by: Prasad Katti Co-authored-by: jannfis Co-authored-by: Torbjørn Fjørtoft Co-authored-by: Scott Windsor Co-authored-by: Mike Splain Co-authored-by: Jake Burn Co-authored-by: Surya Asriadie Co-authored-by: gdsoumya <44349253+gdsoumya@users.noreply.github.com> Co-authored-by: Brad West Co-authored-by: iam-veeramalla Co-authored-by: Oreon Lothamer <73498677+oreonl@users.noreply.github.com> Co-authored-by: rumstead <37445536+rumstead@users.noreply.github.com> Co-authored-by: Cezar Sá Espinola Co-authored-by: Ashutosh Pednekar Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: HYH <82195407@qq.com> Co-authored-by: Mathias Petermann Co-authored-by: David Marby Co-authored-by: Antoine Jouve Co-authored-by: Alejandro López Co-authored-by: Liam Wyllie Co-authored-by: Marcelo Mello Co-authored-by: Ansuman Swain Co-authored-by: Maxime Brunet Co-authored-by: Zubair Haque Co-authored-by: Harm Matthias Harms Co-authored-by: Kurt King Co-authored-by: Kurt Madel Co-authored-by: LStuker Co-authored-by: Lev Ozeryansky Co-authored-by: Lev Co-authored-by: Sergio Rua <58211930+digiserg@users.noreply.github.com> Co-authored-by: Sridhar Nandigam Co-authored-by: Muhammad Mooneeb Hussain Co-authored-by: Timoses Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com> Co-authored-by: Justin Marquis <76892343+34fathombelow@users.noreply.github.com> Co-authored-by: Mike Ng Co-authored-by: ymktmk <73768462+ymktmk@users.noreply.github.com> Co-authored-by: ericblackburn Co-authored-by: PranitRout07 <102309095+PranitRout07@users.noreply.github.com> Co-authored-by: SergeyLadutko <40435115+SergeyLadutko@users.noreply.github.com> Co-authored-by: sergey.ladutko Co-authored-by: Anand Francis Joseph Co-authored-by: Remington Breeze --- docs/operator-manual/custom-styles.md | 2 +- ui/src/app/ui-banner/ui-banner.tsx | 96 +++++++++++++++++++-------- 2 files changed, 70 insertions(+), 28 deletions(-) diff --git a/docs/operator-manual/custom-styles.md b/docs/operator-manual/custom-styles.md index 8f2499a2d636a..893720f7bc9c0 100644 --- a/docs/operator-manual/custom-styles.md +++ b/docs/operator-manual/custom-styles.md @@ -100,7 +100,7 @@ experience, you may wish to build a separate project using the [Argo CD UI dev s ## Banners -Argo CD can optionally display a banner that can be used to notify your users of upcoming maintenance and operational changes. This feature can be enabled by specifying the banner message using the `ui.bannercontent` field in the `argocd-cm` ConfigMap and Argo CD will display this message at the top of every UI page. You can optionally add a link to this message by setting `ui.bannerurl`. You can also make the banner sticky (permanent) by setting `ui.bannerpermanent` to `true` and change it's position to the bottom by using `ui.bannerposition: "bottom"` +Argo CD can optionally display a banner that can be used to notify your users of upcoming maintenance and operational changes. This feature can be enabled by specifying the banner message using the `ui.bannercontent` field in the `argocd-cm` ConfigMap and Argo CD will display this message at the top of every UI page. You can optionally add a link to this message by setting `ui.bannerurl`. You can also make the banner sticky (permanent) by setting `ui.bannerpermanent` to true and change its position to "both" or "bottom" by using `ui.bannerposition: "both"`, allowing the banner to display on both the top and bottom, or `ui.bannerposition: "bottom"` to display it exclusively at the bottom. ### argocd-cm ```yaml diff --git a/ui/src/app/ui-banner/ui-banner.tsx b/ui/src/app/ui-banner/ui-banner.tsx index 53508b67690f7..29dbc45eadfbc 100644 --- a/ui/src/app/ui-banner/ui-banner.tsx +++ b/ui/src/app/ui-banner/ui-banner.tsx @@ -8,6 +8,46 @@ import {DataLoader} from '../shared/components'; import {services, ViewPreferences} from '../shared/services'; import './ui-banner.scss'; +const CustomBanner = (props: { + combinedBannerClassName: string; + show: boolean; + heightOfBanner: string; + leftOffset: string; + permanent: boolean; + url: string; + content: string; + setVisible: (visible: boolean) => void; + prefs: object; +}) => { + return ( +
+
+ {props.url !== undefined ? ( + + {props.content} + + ) : ( + {props.content} + )} +
+ {!props.permanent ? ( + <> + + + + ) : ( + <> + )} +
+ ); +}; + export const Banner = (props: React.Props) => { const [visible, setVisible] = React.useState(true); return ( @@ -60,9 +100,8 @@ export const Banner = (props: React.Props) => { const isTop = position !== 'bottom'; const bannerClassName = isTop ? 'ui-banner-top' : 'ui-banner-bottom'; const wrapperClassname = bannerClassName + '--wrapper ' + (!permanent ? bannerClassName + '--wrapper-multiline' : bannerClassName + '--wrapper-singleline'); - const combinedBannerClassName = isTop ? 'ui-banner ui-banner-top' : 'ui-banner ui-banner-bottom'; let chatBottomPosition = 10; - if (show && !isTop) { + if (show && (!isTop || position === 'both')) { if (permanent) { chatBottomPosition = 40; } else { @@ -77,33 +116,36 @@ export const Banner = (props: React.Props) => { chatUrl = 'invalid-url'; } } + const shouldRenderTop = position === 'top' || position === 'both'; + const shouldRenderBottom = position === 'bottom' || position === 'both'; return ( -
-
- {url !== undefined ? ( - - {content} - - ) : ( - {content} - )} -
- {!permanent ? ( - <> - - - - ) : ( - <> - )} -
+ {shouldRenderTop && ( + + )} + {shouldRenderBottom && ( + + )} {show ?
{props.children}
: props.children} {chatUrl && (