Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly Typescript Fork #18

Open
halostatue opened this issue Nov 29, 2023 · 0 comments
Open

Friendly Typescript Fork #18

halostatue opened this issue Nov 29, 2023 · 0 comments

Comments

@halostatue
Copy link

I was getting TS2349 when editing my project's vite.config.ts related to the exported default del function.

We have forked this project into kineticcafe/rollup-plugin-delete and released it as @kineticcafe/rollup-plugin-delete.

The main changes are:

  1. Port to Typescript
  2. Make it ESM-only (I consider this a minor failure, but I could not figure out the correct incantations)
  3. Use vitest instead of jest
  4. Update all the dependencies
  5. Use GitHub Actions instead of Travis

We are happy to contribute these changes back upstream and retire our repository, but wanted to raise visibility and thank you for work that was easy to port. Aside from some renames and different imports, we were able to reuse all of the tests‡.

‡ We did have to make one configuration change to prevent the use of workers / threads by vitest, which is the default, because process.chdir is not thread-local.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant