Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProxyGenerator doesn't include type's full name embedded in the generic type #77

Open
tjaskula opened this issue Dec 4, 2019 · 2 comments
Labels
bug Something isn't working good for first contribution Help wanted. It's a good issue to get your foot on the ladder proxy-generation Related issue to Proxy Generator

Comments

@tjaskula
Copy link
Contributor

tjaskula commented Dec 4, 2019

If the parameter is generic (or return type) the concrete generic types should also be prefixed with the namespace.

This is what is actually generated IDispatcher<Dispatchable<T, TState>>

The should have Some.Namespace.IDispatcher<Some.Other.Namespace.Dispatchable<T, TState>> instead

@tjaskula tjaskula added bug Something isn't working good for first contribution Help wanted. It's a good issue to get your foot on the ladder proxy-generation Related issue to Proxy Generator labels Dec 4, 2019
@mihaj
Copy link
Member

mihaj commented Feb 23, 2020

@tjaskula please give me a concrete example, so I can write some tests.

@tjaskula
Copy link
Contributor Author

tjaskula commented Mar 4, 2020

@mihaj I think that if you pull vlingo-net-http and delete the file https://github.com/vlingo-net/vlingo-net-http/blob/0b45c98a07d2890289c44a7e746cef7eaee6b288/src/Vlingo.Http/Resource/Dispatcher__Proxy.cs and run the tests, it will try to recreate the proxy and will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good for first contribution Help wanted. It's a good issue to get your foot on the ladder proxy-generation Related issue to Proxy Generator
Projects
None yet
Development

No branches or pull requests

2 participants