Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit all FIXME's and TODO's inside code #161

Open
Florian-Schoenherr opened this issue Nov 9, 2020 · 3 comments
Open

Revisit all FIXME's and TODO's inside code #161

Florian-Schoenherr opened this issue Nov 9, 2020 · 3 comments

Comments

@Florian-Schoenherr
Copy link
Contributor

Coming from #160, we need to find out what parts of the code still really need to be fixed/done.
Main priority is what was mentioned in the issue: what was this line, where null was collector before supposed to do?

And while I'm at it, I would like to also fix the other TODO/FIXME's around the code. Maybe pointing to new issues. But I'm not certain which parts of it are still relevant.
I hope that people who already worked on some of the non-ui code can help me out.
As far as I know, @pflueras did ES-CQRS, so you will probably know a lot about the code base.
If anyone else would know more about certain TODO/FIXME's, please @ them here.

@Florian-Schoenherr
Copy link
Contributor Author

CodeResource.queryContextWith, is probably just old and not needed? There is a ContextData inside CodeResource.Collector, maybe it was to be used for that.

@VaughnVernon
Copy link
Contributor

@Florian-Schoenherr These kinds of issues will all go into a separate backlog if they have merit. We can determine the actual needs later.

@Florian-Schoenherr
Copy link
Contributor Author

@VaughnVernon for now, I hope someone knows about the "CodeResource context"-thing, at least. All the other stuff can go on the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants