-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Recipe creation flow: Directly convert Modifier
Instances to Recipe
#48
base: main
Are you sure you want to change the base?
Conversation
af9c085
to
a1a2bcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending test
@@ -3,10 +3,8 @@ | |||
import pytest | |||
import yaml | |||
|
|||
from llmcompressor.modifiers import Modifier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a new test for a list of modifiers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Ben!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add in a test case the tests the bug reported in #37? Reproduced on a tiny model of course. Otherwise LGTM, just make sure to manually run the unit tests before merging since GHA is broken for all the tests requiring runners
a1a2bcf
to
a9c0dfe
Compare
Added e2e tests in last commit and ran them manually:
|
1bf5e72
to
57bc430
Compare
… Recipe Signed-off-by: Rahul Tuli <[email protected]>
Signed-off-by: Rahul Tuli <[email protected]>
Signed-off-by: Rahul Tuli <[email protected]>
57bc430
to
a8e3894
Compare
This PR refactors the Recipe creation process. The original flow converted Modifier Instances to a recipe string before creating a Recipe. We've simplified this by directly converting Modifier Instances to a Recipe.
from_modifiers
to create a Recipe from Modifier Instances directly.Test plan:
Tested using the scripts/recipes from #37.
Added automated e2e tests: