Increase Sparsity Threshold for compressors #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
kylesayrs
approved these changes
Sep 26, 2024
kylesayrs
previously approved these changes
Sep 26, 2024
mgoin
reviewed
Sep 26, 2024
Thanks to suggestion from @mgoin Co-authored-by: Michael Goin <[email protected]>
mgoin
approved these changes
Sep 26, 2024
horheynm
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During internal testing, it was found that a sparsity threshold of 0.2 is insufficient. In some cases, applying quantization alone can naturally lead to a 20% sparsity level. To address this, this PR increases the sparsity threshold to 0.3.
Please note that this adjustment specifically pertains to sparse compression.