Record config file name as test suite property #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
Signed-off-by: Domenic Barbuzzi <[email protected]>
Signed-off-by: Domenic Barbuzzi <[email protected]>
Signed-off-by: Domenic Barbuzzi <[email protected]>
Signed-off-by: Domenic Barbuzzi <[email protected]>
dbarbuzzi
force-pushed
the
unique-deterministic-e2e-test-names
branch
from
347c1d5 to
3919f49
Compare
dsikka
reviewed
Dec 2, 2024
Signed-off-by: Domenic Barbuzzi <[email protected]>
kylesayrs
approved these changes
Dec 12, 2024
horheynm
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
This PR updates the e2e tests to record the config file used as a property on the testsuite which is written to the JUnit XML report file, which gets used downstream to uniquely identify the tests so they can be tracked over time (currently for elapsed time).
I also added an extra skip-guard to the
test_vllmtest around the required environment variable and updated thepytestcommand usage to include “reasons” for all tests that don’t pass. This means that skip reasons/short error messages/etc. will all be logged at the end of the test results (it does not affect anything else).TEST PLAN:
CADENCE=nightly bash tests/e2e/vLLM/run_tests.shto verify all things pass and that the test reports contain the expected new data.