Composability with sparse and quantization compressors #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
dsikka
reviewed
Dec 2, 2024
| @@ -37,7 +36,8 @@ def infer_quantization_format( | |||
| if save_compressed: | |||
| weight_args, input_args = _get_unique_quant_args(model) | |||
| is_24_structure = ( | |||
| sparsity_config and sparsity_config.sparsity_structure == "2:4" | |||
| SparsityStructure(sparsity_structure).value | |||
| == SparsityStructure.TWO_FOUR.value | |||
There was a problem hiding this comment.
It seems like we've only enabled this to save using the marlin-24 compressor if the model follows 2:4 sparsity?
There was a problem hiding this comment.
nit: can we not compare the enums directly without .value?
There was a problem hiding this comment.
@kylesayrs accepted
There was a problem hiding this comment.
@dsikka let's sync offline
rahul-tuli
force-pushed
the
composability-v2
branch
from
6b47ecd to
ea8b8b5
Compare
Increase Sparsity Threshold Signed-off-by: Rahul Tuli <[email protected]>
Signed-off-by: Rahul Tuli <[email protected]>
Signed-off-by: Rahul Tuli <[email protected]>
rahul-tuli
force-pushed
the
composability-v2
branch
from
9249158 to
afc0b5f
Compare
rahul-tuli
changed the title
horheynm
approved these changes
Dec 3, 2024
|
verified decompression works for sparse and quantized model |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables accomplishes the following: