Skip to content

Conversation

@kyuyeunk
Copy link
Collaborator

@kyuyeunk kyuyeunk commented Nov 5, 2025

Description

  • Same functionality can be achieve with vllm argument --load-format=dummy
  • It is better to remove duplicate configs to avoid confusion from users
  • Similar PR: Remove SKIP_JAX_PRECOMPILE #1018

Tests

https://buildkite.com/tpu-commons/tpu-inference-ci/builds/4948

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@kyuyeunk kyuyeunk requested review from jrplatin and py4 November 5, 2025 11:54
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@kyuyeunk kyuyeunk force-pushed the deprecate_jax_random_weights branch 2 times, most recently from d852c82 to c48b590 Compare November 11, 2025 07:30
@kyuyeunk kyuyeunk force-pushed the deprecate_jax_random_weights branch 2 times, most recently from 628020a to bcb4c98 Compare November 11, 2025 16:19
Signed-off-by: Kyuyeun Kim <[email protected]>
@kyuyeunk kyuyeunk force-pushed the deprecate_jax_random_weights branch from bcb4c98 to fb71fa7 Compare November 11, 2025 16:20
@kyuyeunk kyuyeunk merged commit 0d7e995 into main Nov 11, 2025
3 checks passed
@kyuyeunk kyuyeunk deleted the deprecate_jax_random_weights branch November 11, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants