Skip to content

Commit

Permalink
update templates by adding option to disable the use of the Amazon EC…
Browse files Browse the repository at this point in the history
…2 instance metadata service
  • Loading branch information
mfournioux committed Nov 28, 2024
1 parent f0ac67c commit bd9db73
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
3 changes: 2 additions & 1 deletion examples/chart-helm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,10 @@ The command removes all the Kubernetes components associated with the chart **in
| deploymentStrategy | object | `{}` | Deployment strategy configuration |
| externalConfigs | list | `[]` | External configuration |
| extraContainers | list | `[]` | Additional containers configuration |
| extraInit | object | `{"pvcStorage":"1Gi","s3modelpath":"relative_s3_model_path/opt-125m"}` | Additional configuration for the init container |
| extraInit | object | `{"pvcStorage":"1Gi","s3modelpath":"relative_s3_model_path/opt-125m", "awsEc2MetadataDisabled": true}` | Additional configuration for the init container |
| extraInit.pvcStorage | string | `"50Gi"` | Storage size of the s3 |
| extraInit.s3modelpath | string | `"relative_s3_model_path/opt-125m"` | Path of the model on the s3 which hosts model weights and config files |
| extraInit.awsEc2MetadataDisabled | boolean | `true` | Disables the use of the Amazon EC2 instance metadata service |
| extraPorts | list | `[]` | Additional ports configuration |
| gpuModels | list | `["TYPE_GPU_USED"]` | Type of gpu used |
| image | object | `{"command":["vllm","serve","/data/","--served-model-name","opt-125m","--host","0.0.0.0","--port","8000"],"repository":"vllm/vllm-openai","tag":"latest"}` | Image configuration |
Expand Down
2 changes: 1 addition & 1 deletion examples/chart-helm/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ runAsUser:
- name: S3_PATH
value: "{{ .Values.extraInit.s3modelpath }}"
- name: AWS_EC2_METADATA_DISABLED
value: "true"
value: "{{ .Values.extraInit.awsEc2MetadataDisabled }}"
{{- end }}

{{/*
Expand Down
6 changes: 5 additions & 1 deletion examples/chart-helm/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,15 @@
},
"pvcStorage": {
"type": "string"
},
"awsEc2MetadataDisabled": {
"type": "boolean"
}
},
"required": [
"pvcStorage",
"s3modelpath"
"s3modelpath",
"awsEc2MetadataDisabled"
]
},
"extraContainers": {
Expand Down
1 change: 1 addition & 0 deletions examples/chart-helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ extraInit:
s3modelpath: "relative_s3_model_path/opt-125m"
# -- Storage size of the s3
pvcStorage: "1Gi"
awsEc2MetadataDisabled: true

# -- Additional containers configuration
extraContainers: []
Expand Down

0 comments on commit bd9db73

Please sign in to comment.