Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[help wanted]: rename vllm/logging module to avoid shadowing builtin logging module #10133

Closed
1 task done
youkaichao opened this issue Nov 7, 2024 · 0 comments · Fixed by #10134
Closed
1 task done
Labels

Comments

@youkaichao
Copy link
Member

Anything you want to discuss about vllm.

see #2021 (comment) for more details.

we'd better avoid having a module that can potentially shadow python's builtin module, so that error trace can be clear.

solution could be:

rename vllm.logging to vllm.logging_utils

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant