Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: logging request_id instead of random uuid #11050

Closed
1 task done
cynial opened this issue Dec 10, 2024 · 1 comment
Closed
1 task done

[Feature]: logging request_id instead of random uuid #11050

cynial opened this issue Dec 10, 2024 · 1 comment

Comments

@cynial
Copy link

cynial commented Dec 10, 2024

🚀 The feature, motivation and pitch

vLLM now supports the x-request-id header, as discussed in this issue: #9593.

However, during the completion process, a random ID is still being used. Could we consider using the x-request-id instead? This change would enhance our ability to trace requests more effectively.

For reference, see the current implementation here:
https://github.com/vllm-project/vllm/blob/main/vllm/entrypoints/openai/serving_completion.py#L89

request_id = f"cmpl-{random_uuid()}" :

Alternatives

No response

Additional context

No response

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@DarkLight1337
Copy link
Member

This should be implemented by #10968 already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants