Skip to content

[Doc]: The description about InternVL's support for LoRA in the document does not conform to the reality #18820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
scottxie123 opened this issue May 28, 2025 · 2 comments · Fixed by #18842
Closed
1 task done

[Doc]: The description about InternVL's support for LoRA in the document does not conform to the reality #18820

scottxie123 opened this issue May 28, 2025 · 2 comments · Fixed by #18842
Labels
documentation Improvements or additions to documentation

Comments

@scottxie123
Copy link

📚 The doc issue

The documentation clearly states that LoRA for InternVL is supported, but there is no relevant implementation in the code.

Suggest a potential alternative/fix

No response

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@scottxie123 scottxie123 added the documentation Improvements or additions to documentation label May 28, 2025
@jeejeelee
Copy link
Collaborator

Currently, this model doesn't support LoRA yet. I will add LoRA support for this model ASAP

@jeejeelee jeejeelee mentioned this issue May 28, 2025
Merged
@jeejeelee
Copy link
Collaborator

@scottxie123 Can you test if #18842 fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[LoRA] Add LoRA support for InternVL jeejeelee/vllm
2 participants
@jeejeelee @scottxie123