-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E5-mistral-7b-instruct embedding support #2936
Comments
very interesting and important feature! |
Looking forward to this featrue too! |
Any update on this? |
@Opdoop it was merged to main branch last week via issue 3737 |
Closed as completed by #3734. |
I started this model using a daemonset over my GPU nodepool on AKS. when used the example code to https://docs.vllm.ai/en/latest/getting_started/examples/openai_embedding_client.html hit the api from openai import OpenAI Modify OpenAI's API key and API base to use vLLM's API server.openai_api_key = "EMPTY" client = OpenAI( models = client.models.list() responses = client.embeddings.create(input=["Hello my name is","The best thing about vLLM is that it supports many different models"],model=model) for data in responses.data: i am facing this error. File "E:\o_env\lib\site-packages\openai_base_client.py", line 1030, in _request What should I pass to the client for correct respond. |
base64 embedding is not supported yet, so for now you need to pass |
Hi :)
I noticed in the roadmap that embedding support is intended, and was wondering whether it includes llms such as mistral as well.
Specifically, e5_mistral has the added benefit of including only the adapter in the HF repo. so in this case we could deploy a single pod for both inference as well as truly SOTA embedding without added costs.
I assume it would be easier to implement since decoder only architectures are already supported.
I think e5_mistral the tweak should be to add a function LLMEngine that would take the last hidden state rather than sample on the output yes? if so, i could try and add the pr myself
please let me know if theres anything i could do to help.
The text was updated successfully, but these errors were encountered: