From 6ef3d69da1c18723479d084ac8a733ffd17bc993 Mon Sep 17 00:00:00 2001
From: Chris Werner Rau <cwrau@cwrau.info>
Date: Mon, 16 Oct 2023 12:01:32 +0200
Subject: [PATCH] fix(velero): remove useless `nodeAgent.privileged` this
 clashes with the field `nodeAgent.containerSecurityContext.privileged`

Signed-off-by: Chris Werner Rau <cwrau@cwrau.info>
---
 charts/velero/Chart.yaml                          | 2 +-
 charts/velero/README.md                           | 4 ++++
 charts/velero/templates/node-agent-daemonset.yaml | 1 -
 charts/velero/values.yaml                         | 1 -
 4 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/charts/velero/Chart.yaml b/charts/velero/Chart.yaml
index 32f157a2..27ac0754 100644
--- a/charts/velero/Chart.yaml
+++ b/charts/velero/Chart.yaml
@@ -3,7 +3,7 @@ appVersion: 1.12.0
 kubeVersion: ">=1.16.0-0"
 description: A Helm chart for velero
 name: velero
-version: 5.1.0
+version: 5.1.1
 home: https://github.com/vmware-tanzu/velero
 icon: https://cdn-images-1.medium.com/max/1600/1*-9mb3AKnKdcL_QD3CMnthQ.png
 sources:
diff --git a/charts/velero/README.md b/charts/velero/README.md
index 1ed1022e..a8b1b8c4 100644
--- a/charts/velero/README.md
+++ b/charts/velero/README.md
@@ -90,6 +90,10 @@ helm upgrade vmware-tanzu/velero <RELEASE NAME> --reuse-values --set configurati
 
 ## Upgrading
 
+### Upgrading to 5.1.1
+
+This version removes the `nodeAgent.privleged` field, you should use `nodeAgent.containerSecurityContext.privileged` instead
+
 ### Upgrading to v1.12
 
 The [instructions found here](https://velero.io/docs/v1.12/upgrade-to-1.12/) will assist you in upgrading from version v1.11.x to v1.12.
diff --git a/charts/velero/templates/node-agent-daemonset.yaml b/charts/velero/templates/node-agent-daemonset.yaml
index f503b524..0e209e5d 100644
--- a/charts/velero/templates/node-agent-daemonset.yaml
+++ b/charts/velero/templates/node-agent-daemonset.yaml
@@ -172,7 +172,6 @@ spec:
           lifecycle: {{ toYaml .Values.nodeAgent.lifecycle | nindent 12 }}
           {{- end }}
           securityContext:
-            privileged: {{ .Values.nodeAgent.privileged }}
             {{- with $containerSecurityContext }}
               {{- toYaml . | nindent 12 }}
             {{- end }}
diff --git a/charts/velero/values.yaml b/charts/velero/values.yaml
index 65d986d0..b725a77a 100644
--- a/charts/velero/values.yaml
+++ b/charts/velero/values.yaml
@@ -494,7 +494,6 @@ deployNodeAgent: false
 
 nodeAgent:
   podVolumePath: /var/lib/kubelet/pods
-  privileged: false
   # Pod priority class name to use for the node-agent daemonset. Optional.
   priorityClassName: ""
   # Resource requests/limits to specify for the node-agent daemonset deployment. Optional.