Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary requests made during token refresh #1046

Open
enj opened this issue Mar 3, 2022 · 1 comment
Open

Unnecessary requests made during token refresh #1046

enj opened this issue Mar 3, 2022 · 1 comment
Labels
bug Something isn't working priority/undecided Not yet prioritized

Comments

@enj
Copy link
Contributor

enj commented Mar 3, 2022

Fosite misinterprets the CLI's attempt to refresh via the basic auth header to mean that it is actually trying to authenticate as a public client (even though the client secret is empty):

token_handler.go:50] "token request error" name="invalid_client" status="Unauthorized" description="Client authentication failed (e.g., unknown client, no client authentication included, or unsupported authentication method). The OAuth 2.0 Client supports client authentication method 'none', but method 'client_secret_basic' was requested. You must configure the OAuth 2.0 client's 'token_endpoint_auth_method' value to accept 'client_secret_basic'." debug=""

This slows down the refresh flow because it adds a pointless POST request and it leads to some really confusing messages in our logs.

I opened ory/fosite#655 in an attempt to fix this (see more detailed explanation of the issue there).

This issue tracks getting this resolved upstream and our dependencies updated downstream.

@pinniped-ci-bot pinniped-ci-bot added enhancement New feature or request priority/backlog Prioritized for an upcoming iteration bug Something isn't working and removed enhancement New feature or request labels Mar 3, 2022
@pinniped-ci-bot pinniped-ci-bot added priority/undecided Not yet prioritized and removed priority/backlog Prioritized for an upcoming iteration labels Apr 19, 2022
@pinniped-ci-bot pinniped-ci-bot added priority/backlog Prioritized for an upcoming iteration and removed priority/undecided Not yet prioritized labels Apr 29, 2022
@enj
Copy link
Contributor Author

enj commented Apr 29, 2022

ory/fosite#655 was merged and included in ory/fosite@v0.42.1...v0.42.2 which we picked up in #1131 and released in v0.16.0. We should validate that in v0.15.0, refresh flows had the scary log message noted above, and that in v0.16.0 we no longer see the scary log message. Afterwards we can update the release note to mention that this was also fixed.

@pinniped-ci-bot pinniped-ci-bot added priority/undecided Not yet prioritized and removed priority/backlog Prioritized for an upcoming iteration labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/undecided Not yet prioritized
Projects
Status: No status
Development

No branches or pull requests

2 participants