Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BackedUpItems thread safe #7148

Closed
anshulahuja98 opened this issue Nov 27, 2023 · 6 comments · Fixed by #8366
Closed

Make BackedUpItems thread safe #7148

anshulahuja98 opened this issue Nov 27, 2023 · 6 comments · Fixed by #8366
Assignees
Milestone

Comments

@anshulahuja98
Copy link
Collaborator

anshulahuja98 commented Nov 27, 2023

Describe the problem/challenge you have

Tracking issue to make BackedUpItems thread safe.

Describe the solution you'd like

If we wish to achieve any level of concurrency across backup operations or restore operations, we need to make sure all of the intermediate trackers which are used are thread safe such that they don't run into concurrency issue.

Similar to the impl of SkippedPvTracker -

func NewSkipPVTracker() *skipPVTracker {

We need to implement BackupUpItems tracker
https://github.com/vmware-tanzu/velero/blob/5d81317d5e0c4efc91e76cdbaad56ce21eed2456/pkg/backup/item_backupper.go#L170C1-L171C63
with mutex lock such that multiple operations can update the status in parallel without concurrency issues.
Setting ground work for: #6165 | #6860

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@anshulahuja98 anshulahuja98 self-assigned this Nov 27, 2023
@weshayutin weshayutin added this to OADP Jan 9, 2024
@reasonerjt reasonerjt added Needs info Waiting for information Needs triage We need discussion to understand problem and decide the priority labels Feb 6, 2024
@reasonerjt
Copy link
Contributor

@anshulahuja98 I know we had some discussion but could you add more details in this issue to make it more self-contained?

@anshulahuja98
Copy link
Collaborator Author

Updated the issue description.
@reasonerjt we can mark this as backlog for now, we don't need to track in 1.14
I'll meanwhile try to get someone from my team to work on this.

@reasonerjt reasonerjt removed 1.14-candidate Needs info Waiting for information Needs triage We need discussion to understand problem and decide the priority labels Feb 6, 2024
Copy link

github-actions bot commented Apr 8, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

Copy link

github-actions bot commented Jun 9, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

@github-actions github-actions bot added the staled label Jun 9, 2024
@sseago sseago removed the staled label Jun 10, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

@sseago sseago removed the staled label Aug 12, 2024
@sseago sseago assigned sseago and unassigned anshulahuja98 Oct 29, 2024
@sseago
Copy link
Collaborator

sseago commented Oct 29, 2024

Reassigning to myself since this is needed for #8334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants