Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The statuses of the CRs should be updated when got errors during the reconciling #7799

Closed
ywk253100 opened this issue May 16, 2024 · 3 comments
Labels

Comments

@ywk253100
Copy link
Contributor

ywk253100 commented May 16, 2024

Currently, some of the controllers only log the errors rather than update them into the status of CRs, this causes

  1. Confuse, users don't know what happened to the CR as the status is stuck in in-progress
  2. Hard to debug, need to check the logs to find out what happened
  3. Hard for the downstream projects to integrate because the downstream projects may depend on the status to decide what is the next step.

For example, if the BSL is unavailable, the DeleteBackupRequest is stuck in InProgress status

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

Copy link

This issue was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2024
@kaovilai
Copy link
Member

Perhaps this should be added to or follow up to #7207? or have this be epic containing #7207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants