CSI Artifacts are not patched in object store after Finalizing Phase

[anshulahuja98]

What steps did you take and what happened:

In the finalizing phase today the backup controller re uploads the backup TarBall. (

velero/pkg/backup/backup.go

Line 756 in 1ec52be

func buildFinalTarball(tr *tar.Reader, tw *tar.Writer, updateFiles map[string]FileForArchive) error {

)
But it does not update CSI related artifacts in the object store.
The CSI gzips with VolumeSNapshotCOntent, VolumeSnapshot etc.

Velero in the CSI plugin BIAv2 implementation does a cleanup of the VolumeSnapshot & recreates VolumeSnapshotContent after the backup goes into finalizing phase.

velero/pkg/util/csi/volume_snapshot.go

Lines 633 to 636 in 28d64c2

	// Make the VolumeSnapshotContent static
	vsc.Spec.Source = snapshotv1api.VolumeSnapshotContentSource{
	SnapshotHandle: vsc.Status.SnapshotHandle,
	}

Given this behavioural gap in velero, the object store is not updated with this recreated VolumeSnapshotContent as the contents are not re uploaded.

This has lead to other behavioural issues in Velero as highlighted in Issue - #7978

What did you expect to happen:

The following information will help us better understand what's going on:

If you are using velero v1.7.0+:
Please use velero debug --backup <backupname> --restore <restorename> to generate the support bundle, and attach to this issue, more options please refer to velero debug --help

If you are using earlier versions:
Please provide the output of the following commands (Pasting long output into a GitHub gist or other pastebin is fine.)

• kubectl logs deployment/velero -n velero
• velero backup describe <backupname> or kubectl get backup/<backupname> -n velero -o yaml
• velero backup logs <backupname>
• velero restore describe <restorename> or kubectl get restore/<restorename> -n velero -o yaml
• velero restore logs <restorename>

Anything else you would like to add:

Environment:

• Velero version (use velero version):
• Velero features (use velero client config get features):
• Kubernetes version (use kubectl version):
• Kubernetes installer & version:
• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

• 👍 for "I would like to see this bug fixed as soon as possible"
• 👎 for "There are more important bugs to focus on right now"

[reasonerjt]

@anshulahuja98 @blackpiglet
This is essentially the reason for #7978, right?
I see we are discussing whether we can skip uploading vsc to BSL and modify the deletion/restore process, if we can reach an agreement this is a good candidate for v1.15 IMO

[anshulahuja98]

Yes @reasonerjt
This is just the rootcause Bug item

And yes I am in favour of removing dependency on VSC for the various flows, we can plan for 1.15

[anshulahuja98]

#7978 (comment)
Link to another explanation of the issue