Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement for cluster-scoped resources restore #8479

Open
AlbeeSo opened this issue Dec 3, 2024 · 2 comments
Open

Enhancement for cluster-scoped resources restore #8479

AlbeeSo opened this issue Dec 3, 2024 · 2 comments

Comments

@AlbeeSo
Copy link
Contributor

AlbeeSo commented Dec 3, 2024

Describe the problem/challenge you have

I met some challenges when backup a large cluster but try to restore only several namespaces like:

  • Additional items added by backup actions, like clusterroles, will not restored automatically.
  • Cannot choose the specified cluster-scoped resources to restore as includedClusterScopedResources in Backup. And set includeClusterResources true may bring unexpected resources.

I think this may because, backup should include resources as much as possible to ensure the applications can run well after migration. But if add additional items in restore should be carefully designed.

Describe the solution you'd like

Is there any solution for such cases?

  • Maybe some related actions can be used in restore to add additional items. And these actions can be optional by flag or feature-gate.
  • Support the new filters in restore to only include the cluster-scoped resources in need.

Anything else you would like to add:

Environment:

  • Velero version (use velero version): v1.15
  • Kubernetes version (use kubectl version): v1.31
  • Kubernetes installer & version: ACK
  • Cloud provider or hardware configuration: Alibaba Cloud
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@sseago
Copy link
Collaborator

sseago commented Dec 3, 2024

This is a known issue, but I can't seem to find a related github issue.

I don't think we need to include any new feature gates or configuration, though. I suspect the right answer would be for any backup item action which returns cluster-scoped resources as additional items we need to create a corresponding restore item action which returns those same additional items (which should then be included in the restore as long as the item was in the backup) -- and for those built-in (non-plugin) cases of PVs and CRDs, to make sure those are included in the restore as well (if they are not already).

@AlbeeSo
Copy link
Contributor Author

AlbeeSo commented Dec 4, 2024

@sseago Thanks for reply~ Is there any plan for this enhancement already? I can help this if need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants