From 525ef18469e2ed083c5c2328cda1d8255fba8a47 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Tue, 28 May 2024 12:58:31 +0100 Subject: [PATCH 1/8] check build on free runners --- projects/vdk-core/src/vdk/api/data_job.py | 2 +- .../vdk-dag/src/vdk/plugin/dag/cached_data_job_executor.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/vdk-core/src/vdk/api/data_job.py b/projects/vdk-core/src/vdk/api/data_job.py index 3a07ef77f4..aaf579f59c 100644 --- a/projects/vdk-core/src/vdk/api/data_job.py +++ b/projects/vdk-core/src/vdk/api/data_job.py @@ -11,7 +11,7 @@ class IStandaloneDataJob: """ A contextmanager that initialises VDK and its plugins, - triggers plugin lifecycle hooks needed to expose an initialised IJobInput on entry + triggers plugin lifec needed to expose an initialised IJobInput on entry and finalization hooks when the context is exited NB: The following plugin hooks are not triggered: diff --git a/projects/vdk-plugins/vdk-dag/src/vdk/plugin/dag/cached_data_job_executor.py b/projects/vdk-plugins/vdk-dag/src/vdk/plugin/dag/cached_data_job_executor.py index 69c82fb266..940f1a9da1 100644 --- a/projects/vdk-plugins/vdk-dag/src/vdk/plugin/dag/cached_data_job_executor.py +++ b/projects/vdk-plugins/vdk-dag/src/vdk/plugin/dag/cached_data_job_executor.py @@ -24,7 +24,7 @@ class TrackingDataJobExecutor: """ - The purpose of this class is to execute Data Jobs, track them and change their + The purpose of is to execute Data Jobs, track them and change their statuses accordingly. """ From d9cba972b6036bdf5a001fdd454bed376e4d1961 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Wed, 29 May 2024 11:22:52 +0100 Subject: [PATCH 2/8] check build on free runners --- projects/vdk-plugins/.plugin-common.yml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/projects/vdk-plugins/.plugin-common.yml b/projects/vdk-plugins/.plugin-common.yml index f3edbcb00e..07f98b82f3 100644 --- a/projects/vdk-plugins/.plugin-common.yml +++ b/projects/vdk-plugins/.plugin-common.yml @@ -46,11 +46,14 @@ .build-plugin-dind: image: docker:23.0.6 services: - - docker:23.0.6-dind - variables: - DOCKER_HOST: tcp://localhost:2375 - DOCKER_DRIVER: overlay2 - DOCKER_TLS_CERTDIR: "" + dind: + image: docker:23.0.6-dind + restart: always + privileged: true + environment: + DOCKER_TLS_CERTDIR: "" + command: + - --storage-driver=overlay2 extends: .build-plugin .release-plugin: From bd80ebce66df4523d2adfa8616f687721dcbcc52 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Wed, 29 May 2024 12:58:58 +0100 Subject: [PATCH 3/8] check build on free runners --- projects/vdk-plugins/.plugin-common.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/vdk-plugins/.plugin-common.yml b/projects/vdk-plugins/.plugin-common.yml index 07f98b82f3..8eef56ffe2 100644 --- a/projects/vdk-plugins/.plugin-common.yml +++ b/projects/vdk-plugins/.plugin-common.yml @@ -46,7 +46,7 @@ .build-plugin-dind: image: docker:23.0.6 services: - dind: + - name: dind image: docker:23.0.6-dind restart: always privileged: true From aeca86f7d6089e4a455a9df680903b17d845c20f Mon Sep 17 00:00:00 2001 From: paulm2 Date: Wed, 29 May 2024 13:09:23 +0100 Subject: [PATCH 4/8] check build on free runners --- projects/vdk-plugins/.plugin-common.yml | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/projects/vdk-plugins/.plugin-common.yml b/projects/vdk-plugins/.plugin-common.yml index 8eef56ffe2..4fadc950db 100644 --- a/projects/vdk-plugins/.plugin-common.yml +++ b/projects/vdk-plugins/.plugin-common.yml @@ -44,16 +44,14 @@ - "projects/vdk-core/src/**/*" .build-plugin-dind: - image: docker:23.0.6 + image: docker:26.1.3 services: - - name: dind - image: docker:23.0.6-dind - restart: always - privileged: true - environment: - DOCKER_TLS_CERTDIR: "" - command: - - --storage-driver=overlay2 + - name: docker:26.1.3-dind + alias: docker + variables: + DOCKER_HOST: tcp://localhost:2375 + DOCKER_DRIVER: overlay2 + DOCKER_TLS_CERTDIR: "" extends: .build-plugin .release-plugin: From befcd6eeb7dc49f85112cfc9d9a22d86151d4cdd Mon Sep 17 00:00:00 2001 From: paulm2 Date: Wed, 29 May 2024 13:10:02 +0100 Subject: [PATCH 5/8] check build on free runners --- projects/vdk-plugins/.plugin-common.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/vdk-plugins/.plugin-common.yml b/projects/vdk-plugins/.plugin-common.yml index 4fadc950db..230e62a764 100644 --- a/projects/vdk-plugins/.plugin-common.yml +++ b/projects/vdk-plugins/.plugin-common.yml @@ -49,7 +49,7 @@ - name: docker:26.1.3-dind alias: docker variables: - DOCKER_HOST: tcp://localhost:2375 + DOCKER_HOST: tcp://docker:2375 DOCKER_DRIVER: overlay2 DOCKER_TLS_CERTDIR: "" extends: .build-plugin From aa23375bcbd5e5cd4fed25da6d25e4d4ecf90739 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Wed, 29 May 2024 13:12:54 +0100 Subject: [PATCH 6/8] check build on free runners --- .../vdk-impala/src/vdk/plugin/impala/impala_configuration.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/impala_configuration.py b/projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/impala_configuration.py index cff9faaf9d..065a16c9ed 100644 --- a/projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/impala_configuration.py +++ b/projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/impala_configuration.py @@ -2,6 +2,10 @@ # SPDX-License-Identifier: Apache-2.0 from vdk.internal.core.config import ConfigurationBuilder + + + + IMPALA_HOST = "IMPALA_HOST" IMPALA_PORT = "IMPALA_PORT" IMPALA_DATABASE = "IMPALA_DATABASE" From 43948d4192686026ae8fc54669734c52353ac6e2 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 29 May 2024 12:13:43 +0000 Subject: [PATCH 7/8] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- .../vdk-impala/src/vdk/plugin/impala/impala_configuration.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/impala_configuration.py b/projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/impala_configuration.py index 065a16c9ed..05bd42623e 100644 --- a/projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/impala_configuration.py +++ b/projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/impala_configuration.py @@ -3,9 +3,6 @@ from vdk.internal.core.config import ConfigurationBuilder - - - IMPALA_HOST = "IMPALA_HOST" IMPALA_PORT = "IMPALA_PORT" IMPALA_DATABASE = "IMPALA_DATABASE" From cb9c59bba8fc0e0c7d74635d19af76d79b0024f2 Mon Sep 17 00:00:00 2001 From: paulm2 Date: Wed, 29 May 2024 14:04:37 +0100 Subject: [PATCH 8/8] check build on free runners --- projects/vdk-plugins/.plugin-common.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/projects/vdk-plugins/.plugin-common.yml b/projects/vdk-plugins/.plugin-common.yml index 230e62a764..b991d00f63 100644 --- a/projects/vdk-plugins/.plugin-common.yml +++ b/projects/vdk-plugins/.plugin-common.yml @@ -46,10 +46,9 @@ .build-plugin-dind: image: docker:26.1.3 services: - - name: docker:26.1.3-dind - alias: docker + - docker:26.1.3-dind variables: - DOCKER_HOST: tcp://docker:2375 + DOCKER_HOST: tcp://localhost:2375 DOCKER_DRIVER: overlay2 DOCKER_TLS_CERTDIR: "" extends: .build-plugin