Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mastodon sharing button does not properly handle cancellation and empty input #755

Closed
Marcono1234 opened this issue Dec 31, 2024 · 1 comment

Comments

@Marcono1234
Copy link

Description

The recently introduced button for sharing a video on Mastodon does not properly handle when the browser dialog for the Mastodon domain is cancelled or the input field is left empty.

In both cases it constructs incorrect URLs and tries to open them.

Expected behavior

When the browser dialog is cancelled or an empty value is provided by the user, sharing should be aborted and no website should be opened.

Reproduction steps

  1. Open for example https://media.ccc.de/v/38c3-wir-wissen-wo-dein-auto-steht-volksdaten-von-volkswagen
  2. Click the Mastodon sharing button at the bottom of the screen
    ℹ️ Note: A browser dialog appears, asking you for the domain of the Mastodon server
  3. Click "Cancel" on the dialog
    ❌ Bug: It uses null as domain
@QbDesu
Copy link
Collaborator

QbDesu commented Jan 6, 2025

Was fixed in 535efbf

@QbDesu QbDesu closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants