Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: refactor indexer restore #1324

Open
altergui opened this issue Jun 3, 2024 · 1 comment
Open

bug: refactor indexer restore #1324

altergui opened this issue Jun 3, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@altergui
Copy link
Contributor

altergui commented Jun 3, 2024

right now indexer backup is not checksummed (nor deterministic) and can potentially differ from node to node. if a rogue node publishes an incomplete indexer, a bootstrapping node can pull that broken indexer during the statesync init.

@p4u proposes removing the indexer backup from the state snapshot, and implementing some out-of-band mechanism, for example an "authoritative" node that maintains the complete indexer and publishes the resulting backup over ipns (very much like the archiver). that would be pulled during ApplySnapshotChunk, when the height of the state is already known. if there's any failure, our code would simply report to cometbft that the whole statesync failed and cometbft would try again, with another snapshot (and height, possibly)

@altergui altergui added the bug Something isn't working label Jun 3, 2024
@altergui altergui self-assigned this Jun 3, 2024
@altergui
Copy link
Contributor Author

another related idea is to implement a "consistency check" on indexer, that for example recalculates the elections results looking at the state, and verifies the indexer has the same results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant