integrate census3 api client #50
Conversation
| ) | ||
|
|
||
| // Client wraps a client for the Census3 API and other revelant data. | ||
| type Client struct { |
There was a problem hiding this comment.
tbh I'm not sure for the need of this wrapper of the census3 client (which is already a wrapper for the API).
The retry mechanism could also be implemented on the original client instead of here.
What's the point @jordipainan ?
There was a problem hiding this comment.
I like to wrap these kind of imports so they can be extended on the consumer, imo adds more flexibility i.e: a new attribute needs to be added.
I dont think the retry mechanism should be added on the base client, and I think thats up to the consumer too. The base client needs to be simplest as possible and the retry mechanism is something one may decide to add or not.
There was a problem hiding this comment.
Most of the methods for the wrapper are just calls to the census3 client with the retry helper. I still don't see the reason to have this wrapper, tbh.
Adding a wrapper adds complexity, and I'm not sure about the flexibility thing. Keep it simple if possible.
Anyway, let's call for more feedback @lucasmenendez
p4u
force-pushed
the
main
branch
5 times, most recently
from
440ac39
to
043e65e
Compare
p4u
force-pushed
the
main
branch
10 times, most recently
from
fb096fb
to
cff04f7
Compare
p4u
force-pushed
the
main
branch
3 times, most recently
from
74645c8
to
c3664a2
Compare
related #36