Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Poor audio quality when using Google Synthesizer #628

Closed
jstahlbaum-fibernetics opened this issue Jul 11, 2024 · 4 comments
Closed

[Bug]: Poor audio quality when using Google Synthesizer #628

jstahlbaum-fibernetics opened this issue Jul 11, 2024 · 4 comments
Labels
bug Something isn't working stale

Comments

@jstahlbaum-fibernetics
Copy link
Contributor

Brief Description

I noticed some issues with the GoogleSynthesizer class during development. It seams to importing the old version of the library causing a compile error. The sample rate seems fixed when it could use the config. There is garbage data because the class is not stripping the wav header off the response from google. Not sure if it was intentional but that synthesizer was also removed from the default factor during the transition between version 111 and 113

LLM

None

Transcription Services

None

Synthesis Services

Google Cloud

Telephony Services

None

Conversation Type and Platform

No response

Steps to Reproduce

-Create a custom Synthiziser and override the create_synthesizer

  • add the GoogleSynthesizer(synthesizer_config) as a possible option
  • Setup a simple test with the speller agent and use the GoogleSynthesizer as the synthesis
  • Notice there are coding errors and poor audio outputed

Expected Behavior

Since this class was previously included, i think it should continue to be functional

Screenshots

No response
@jstahlbaum-fibernetics jstahlbaum-fibernetics added the bug Something isn't working label Jul 11, 2024
@jstahlbaum-fibernetics
Copy link
Contributor Author

Pull Request provided to address found issue: #629

@parshvadaftari
Copy link

parshvadaftari commented Jul 12, 2024 •
edited
Loading

Hii @jstahlbaum-fibernetics ! Are the changes which you made running on your local? Also please do run the tests using make test.

ajar98 added a commit that referenced this issue Jul 12, 2024
@jstahlbaum-fibernetics @ajar98
[Bug #628] correct coding errors in the google synthesiser (#629)
ad1adc8 
* [Bug-628] correct coding errors in the google synthesiser

* create_speech --> create_speech_uncached

---------

Co-authored-by: Ajay Raj <[email protected]>
ajar98 added a commit that referenced this issue Jul 12, 2024
@ajar98 @jstahlbaum-fibernetics
Update vocodehq-public (#631)
2eb0115 
* [Bug #628] correct coding errors in the google synthesiser (#629)

* [Bug-628] correct coding errors in the google synthesiser

* create_speech --> create_speech_uncached

---------

Co-authored-by: Ajay Raj <[email protected]>

* [DOW-119] creates AudioPipeline abstraction (#625)

* make terminate async

* creates audio pipeline abstraction

* fix streaming conversation api

* make terminate() invocations in tests async

* removes the vector_db.tear_down() call in streaming conversation

---------

Co-authored-by: jstahlbaum-fibernetics <[email protected]>
ajar98 added a commit that referenced this issue Jul 12, 2024
@jstahlbaum-fibernetics @ajar98
[Bug #628] correct coding errors in the google synthesiser (#629)
c317e19 
* [Bug-628] correct coding errors in the google synthesiser

* create_speech --> create_speech_uncached

---------

Co-authored-by: Ajay Raj <[email protected]>
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 11, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically closed due to inactivity. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parshvadaftari @jstahlbaum-fibernetics