Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite input streaming #651

Closed
ajar98 opened this issue Jul 19, 2024 · 3 comments
Closed

Rewrite input streaming #651

ajar98 opened this issue Jul 19, 2024 · 3 comments
Assignees
Labels

Comments

@ajar98
Copy link
Contributor

ajar98 commented Jul 19, 2024

Rewrite input streaming to be built more bespoke into StreamingConversation:

  • Convert BaseSynthesizer into a worker that accepts
  • Convert the process of collating tokens into sentences into a worker (that doesn't include a queue) that is attached to an Agent only if the attached synthesizer is an input streaming synthesizer
  • Rename create_speech_uncached to create_speech (less confusing)

Allows us to dramatically improve the code quality of input streaming and also dramatically simplify agent / synthesizer abstractions

@ajar98 ajar98 self-assigned this Jul 19, 2024
@ajar98 ajar98 converted this from a draft issue Jul 19, 2024
@ajar98 ajar98 linked a pull request Jul 19, 2024 that will close this issue
@ajar98 ajar98 moved this to In Progress in Vocode Core 0.2.0 Jul 19, 2024
@ss14
Copy link

ss14 commented Jul 30, 2024

Hi @ajar98

I have raised an issue #668 about a failing test case. IMO that issue may be fixed after this input streaming rewrite is complete. Let me know you opinion. thanks!

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 29, 2024
Copy link

github-actions bot commented Oct 7, 2024

This issue has been automatically closed due to inactivity. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Vocode Core 0.2.0 Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants