-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: use data from JSON API for purchase URL #127
Comments
|
we can just visit game pages for checking whether if its claimed or not. |
Then there's no real advantage since you'd also have to deal with issues like #120 when you check the page for each game. |
Currently you get links through ui you click buttons. API takes time to change and most of the time not preffered. But game links and even /free-games can change overtime so we have that advantage if we go this route. We can also try claiming 1 by 1 and tell the user we couldn't claim. But to keep details i suggested visiting game page. |
We can play around a bit. I just want to avoid adding more code / situations that complicate debugging / lead to more captchas without a clear advantage (like not checking each game page).
|
Check the PR. I'm always getting a captcha with it, even with a new IP. |
Strange I dont get any captchas with it. |
Maybe another person can confirm if they get one? |
I didn't test it will let you know when i do it. |
Ok, just got no captcha with #130. However, missing the response, seems like it was just a blank page afterwards. |
Yes, The blank page is the end result but It shows thanks for your order for a little bit of time. I'm sure we can capture that by waiting a text just like we did with |
It might be |
https://github.com/AuroPick/epic-free-games I noticed this repository, not sure if it would helpful vs the current method. |
@raulvasquez It can help for listing the game through api and the guy went through the effort and added all of the country codes as well. But still not solving our current problem. |
@raulvasquez Thanks, I added an option |
Page should say |
I'm just getting a blank page: However, waiting for the response above (see 3292257) works. |
So far, #130 saves one |
I will be busy for a month sorry. I'm currently in another place and can't test it right away. |
Will keep you updated when i get on this. |
4e8e8ee URL construction somehow not reliable. |
Tried #130 for Death Stranding on a sep. account and it failed:
|
Changed to main branch: free-games-claimer/epic-games.js Lines 169 to 174 in 4e8e8ee
Does not appear when using #130 which may be another issue. However, that was not the problem and the issue persists.
|
Well then we might only use the parse current free games with api and do the claiming with normally. I'm still busy and didn't try. |
#130 loads https://store.epicgames.com/purchase?offers=1-d5241c76f178492ea1540fce45616757-b951f31da58449cd83d6cb1f4ca62d3a
However, those namespace/id values don't appear in the loaded https://store-site-backend-static-ipv4.ak.epicgames.com/freeGamesPromotions?locale=en-US&country=DE&allowCountries=DE |
Hello there still away from my main pc, What I can say is the safest bet would be parse games with json and do the rest of the things normally it is only a small boost but we'll get what we can get. |
See above. You can base a PR on what I made. I think I won't spent time on it since it's too much brittle code for little gain. |
@WiLuX-Source Any update? If not, I'll close this. |
@vogler you can close this issue we can discuss further when i make pr. |
parse freebies with https://store-site-backend-static-ipv4.ak.epicgames.com/freeGamesPromotions
and put them in a order with a url.
example would be like this
It will make code more future proof.
so it is like creating a url with "store.epicgames.com/purchase?offers=1-{namespace}-{id}
With this way we only handle Authentication with Playwright & Claim it with 1 simple button click.
The text was updated successfully, but these errors were encountered: