-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: game data and purchase URL from JSON API #130
Open
vogler
wants to merge
9
commits into
main
Choose a base branch
from
urlsFromJson
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- old `e.catalogNs.mappings[0].pageSlug` -> base game - https://store.epicgames.com/en-US/p/the-sims-4 - new `e.offerMappings[0].pageSlug` -> add-on - https://store.epicgames.com/en-US/p/the-sims-4--the-daring-lifestyle-bundle
vogler
added
feature
New feature or request
store: epic-games
optimization
and removed
feature
New feature or request
labels
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
purchaseURL
for each game instead of clicking the 'GET' buttonI got a captcha with these changes, but may be due to testing during development.
Problems:
epic-games.json
).Untested:
unavailable-in-region
EG_PARENTALPIN
-> waiting forThanks for your order
confirm-order
-response in 3292257Closes #127.