Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(notebook): fix exporting config files #1072

Closed
wants to merge 9 commits into from
Closed

chore(notebook): fix exporting config files #1072

wants to merge 9 commits into from

Conversation

Onako2
Copy link
Contributor

@Onako2 Onako2 commented Jan 27, 2024 •
edited
Loading

Description of change

Fixes #1071

Google Colab:
Old behavior:

  • Exporting wasn't useable

New behavior:

  • Exporting is usable

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • This pull request follows Contributing.md
  • This pull request links relevant issues as Fixes #1071
  • pre-commit run -a passes with this change or ci passes
  • poetry run pytest passes with this change or ci passes
  • (There are new or updated unit tests validating the change)
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

@codecov Codecov
Copy link

codecov bot commented Jan 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7b2a42) 19.25% compared to head (0e8efc2) 19.25%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1072   +/-   ##
=======================================
  Coverage   19.25%   19.25%           
=======================================
  Files          39       39           
  Lines        3496     3496           
  Branches      497      497           
=======================================
  Hits          673      673           
  Misses       2804     2804           
  Partials       19       19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@34j 34j changed the title fix: Fixed exporting in Google Colab fix: fix exporting config files in Google Colab Jan 28, 2024
@34j 34j changed the title fix: fix exporting config files in Google Colab chore(notebook): fix exporting config files Jan 28, 2024
@Onako2
Copy link
Contributor Author

Onako2 commented Feb 10, 2024

I think now it should be fixed xD. VS-Code fucks up :(

@34j 34j closed this May 10, 2024
@34j
Copy link
Collaborator

34j commented May 10, 2024 •
edited
Loading

Sorry but closing this because of my personal preference, thanks for your suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exporting configs files doesn't work
2 participants
@Onako2 @34j