Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the classic notebook extension #71

Open
jtpio opened this issue Dec 23, 2020 · 5 comments
Open

Deprecate the classic notebook extension #71

jtpio opened this issue Dec 23, 2020 · 5 comments

Comments

@jtpio
Copy link
Member

jtpio commented Dec 23, 2020

This will be a follow-up issue to #69

The idea is to reuse the same components as the ones used for the JupyterLab Extension, by having a standalone lab-based app that shoes the notebook and the editor only. The helps share the same code base and workflows between the lab extension and the classic notebook extension.

This is done in jupyterlab/retrolab#69 in https://github.com/voila-dashboards/voila-gridstack/tree/0d5c9e3504c3d48a3aed004ea64528b7ea905fea/packages/gridstack-editor, and looks like the following:

standalone-editor

The remaining items would be to:

  • Bundle the standalone app in the distribution, for example under voila-gridstack/editor or voila-gridstack/static directly
  • Add a button to the classic notebook UI to open the standalone app in a new browser tab
  • Remove the classic notebook extension
jtpio pushed a commit that referenced this issue Dec 24, 2020
Trigger resize events for bqplot
@jtpio
Copy link
Member Author

jtpio commented Nov 3, 2021

Thinking we might want to start deprecating the classic notebook extension as part of the 0.3.x series.

Not sure whether we should provide the standalone editor as mentioned above. Users could just use JupyterLab instead.

Another option would be to see whether we want to make the current JupyterLab extension compatible with RetroLab.

@hbcarlos
Copy link
Member

hbcarlos commented Nov 3, 2021

I was thinking the same. I would like to make this extension compatible with retrolab instead of using the standalone app.

We need to have two documents open to drag and drop cells from the notebook to the grid. Maybe we could create a map view of the notebook on a side panel?

@jtpio
Copy link
Member Author

jtpio commented Nov 4, 2021

Yes. Probably RetroLab will start exposing the left and right areas at some point: https://github.com/jupyterlab/retrolab/issues/268

These areas will be hidden by default. With menu entries to show them on demand.

@hbcarlos
Copy link
Member

hbcarlos commented Nov 4, 2021

We can start adding the widget to JupyterLab (sometimes it is helpful to open the grid editor without the notebook), and later we can easily create the extension for RetroLab.

These areas will be hidden by default. With menu entries to show them on demand.

I suppose will be a command to open them, so, we can always execute the command when opening the grid editor.

@jtpio
Copy link
Member Author

jtpio commented Nov 4, 2021

We can start adding the widget to JupyterLab (sometimes it is helpful to open the grid editor without the notebook),

By "widget" this means the notebook mini-map? If so that sounds good, and it could go either to the left or right area.

I suppose will be a command to open them

Most likely yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants