You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am putting this here to store the information until we are very close to the parity cut.
The base issue was found when I wrote a quick script to search for plugins that import another plugin, but do not have a Version or Plugin requirement on it. This found quite a few instances throughout the codebase. This will all be fixed at once after the artifact testing is done for Windows and Linux to avoid silly merge conflicts.
The second item that I am working with David is to have our GitHub actions check for these missing requirements during PRs to avoid them getting into the codebase again.
The text was updated successfully, but these errors were encountered:
Plugins don't need to specify a version themselves if they don't have any public interface (classmethods) that could require version information by others, but yep, it would be good to ensure all calls to external modules have the correct version requirements behind them...
I am putting this here to store the information until we are very close to the parity cut.
The base issue was found when I wrote a quick script to search for plugins that import another plugin, but do not have a Version or Plugin requirement on it. This found quite a few instances throughout the codebase. This will all be fixed at once after the artifact testing is done for Windows and Linux to avoid silly merge conflicts.
The second item that I am working with David is to have our GitHub actions check for these missing requirements during PRs to avoid them getting into the codebase again.
The text was updated successfully, but these errors were encountered: