Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple plugins missing version/plugin requirements on imported plugins #1547

Open
atcuno opened this issue Jan 13, 2025 · 2 comments
Open
Assignees

Comments

@atcuno
Copy link
Contributor

atcuno commented Jan 13, 2025

I am putting this here to store the information until we are very close to the parity cut.

The base issue was found when I wrote a quick script to search for plugins that import another plugin, but do not have a Version or Plugin requirement on it. This found quite a few instances throughout the codebase. This will all be fixed at once after the artifact testing is done for Windows and Linux to avoid silly merge conflicts.

The second item that I am working with David is to have our GitHub actions check for these missing requirements during PRs to avoid them getting into the codebase again.

@atcuno atcuno self-assigned this Jan 13, 2025
@skalvino
Copy link

i can't see this 2 files

requirements-minimal.txt
requirements.txt

@ikelos
Copy link
Member

ikelos commented Jan 18, 2025

Plugins don't need to specify a version themselves if they don't have any public interface (classmethods) that could require version information by others, but yep, it would be good to ensure all calls to external modules have the correct version requirements behind them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants