Issues/kvo optional #1601
Open
Issues/kvo optional #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bumps hivescan to take a module name rather than a layer_name/symbol_table combo.
|
I've locally run volshell.py -w with the image, and provided it the same volshell commands, and it worked fine. I've tried it with python 3.8 in case something about the older version was causing problems. I reran the test in case it was a fluke, so far, no issues but the test will not succeed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should verify that the KVO is always defined in various plugins, and otherwise will throw an exception.
For some reason one of the tests fails, and I really can't figure out why. Anyone any guesses? @npetroni ?