Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reclaim: Multiple queues with different priorities sorting #3998

Open
raravena80 opened this issue Feb 6, 2025 · 4 comments
Open

Reclaim: Multiple queues with different priorities sorting #3998

raravena80 opened this issue Feb 6, 2025 · 4 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@raravena80
Copy link
Contributor

raravena80 commented Feb 6, 2025

What is the problem you're trying to solve

Need to enhance if there are multiple queues that are needed to be reclaimed, then we need to check the queue’s priority to sort.

Describe the solution you'd like

Need to enhance if there are multiple queues needed to be reclaimed, then we need to check the queue’s priority to sort.

Additional context

Slack thread: https://cloud-native.slack.com/archives/C011GJDQS0N/p1738809052026239?thread_ts=1738361347.510989&cid=C011GJDQS0N

@raravena80 raravena80 added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 6, 2025
@aryasoni98
Copy link

@raravena80 I would love to work on this issue. Could you please assign it to me?

@bogo-y
Copy link
Contributor

bogo-y commented Feb 7, 2025

This should be an existing feature according to https://github.com/volcano-sh/apis/blob/release-1.11/pkg/apis/scheduling/types.go#L357. And I think it had been implemented at https://github.com/volcano-sh/volcano/blob/release-1.11/pkg/scheduler/framework/session_plugins.go#L826.

@raravena80
Copy link
Contributor Author

/assign @aryasoni98

@JesseStutler
Copy link
Member

JesseStutler commented Feb 8, 2025

This should be an existing feature according to https://github.com/volcano-sh/apis/blob/release-1.11/pkg/apis/scheduling/types.go#L357. And I think it had been implemented at https://github.com/volcano-sh/volcano/blob/release-1.11/pkg/scheduler/framework/session_plugins.go#L826.

Correct, I think it's already solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants