Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for adding require false option in Gemfile #339

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for adding require false option in Gemfile #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25fc8e8
Fix main task file name and placement
kikunantoka Jul 30, 2019
148b983
Add a requirement in a template file
kikunantoka Jul 30, 2019
c7454df
Add require false option in README
kikunantoka Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ See the [installation instructions](https://voormedia.github.io/rails-erd/instal

* Install Graphviz 2.22+ ([how?](https://voormedia.github.io/rails-erd/install.html)). On macOS with Homebrew run `brew install graphviz`.

* Add <tt>gem 'rails-erd', group: :development</tt> to your application's Gemfile
* Add <tt>gem 'rails-erd', require: false, group: :development</tt> to your application's Gemfile

* Run <tt>bundle exec erd</tt>

Expand Down
1 change: 1 addition & 0 deletions lib/generators/erd/templates/auto_generate_diagram.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
# NOTE: are sensitive to local FS writes, and besides -- it's just not proper
# NOTE: to have a dev-mode tool do its thing in production.
if Rails.env.development?
require "rails-erd"
RailsERD.load_tasks
end
2 changes: 1 addition & 1 deletion lib/rails_erd/railtie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module RailsERD
# of your domain model.
class Railtie < Rails::Railtie
rake_tasks do
load "rails_erd/tasks.rake"
load "tasks/erd.rake"
end
end
end
0 lib/rails_erd/tasks.rake → lib/tasks/erd.rake
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion test/unit/rake_task_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class RakeTaskTest < ActiveSupport::TestCase

def setup
require "rake"
load "rails_erd/tasks.rake"
load "tasks/erd.rake"

RailsERD.options.filetype = :dot
RailsERD.options.warn = false
Expand Down