Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the sleep(UINT32_MAX) has exited on OpenWRT instantly #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

halfbakery
Copy link
Contributor

The sleep(UINT32_MAX) has exited instantly on OpenWrt. This fix will work forever :-)

@halfbakery
Copy link
Contributor Author

I forgot to mention, that sleep(INT32_MAX) is working correctly, only the greater values are problematic. It's definetly not a busy loop. The for loop around the sleep is just some extra pedantry:

  • serial2mqtt could run longer than than 68 years :-)
  • theoretically signal handlers could interrupt sleep (currently we don't use signal handlers, but this solution is future proof)

If you have any concerns, please let me know.

@halfbakery
Copy link
Contributor Author

Or we can use a more idiomatic way:

for (;;)
{
    pause();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant