Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout parameter unused #38

Open
Phasip opened this issue Nov 14, 2022 · 0 comments
Open

Timeout parameter unused #38

Phasip opened this issue Nov 14, 2022 · 0 comments

Comments

@Phasip
Copy link

Phasip commented Nov 14, 2022

At first I assumed it was the timeout of each dns-lookup, however it is supposed to be the thread timeout.

In any way, the parameter value does not seem to be used anywhere in the code.
Phasip added a commit to Phasip/resolvers that referenced this issue Nov 14, 2022
@Phasip
Remove timeout, and telegram
eeb7a3b 
Ugly patch to implement: vortexau/dnsvalidator@26705b8

Also stop using timeout as I don't think it does anything? (vortexau/dnsvalidator#38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Phasip