You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why? This would provide a bit more info to users about what is actually happening in our builtin operations. This may be especially useful if there is a builtin operation that uses multiple progress bars, in which case the naive implementation may involve two separate progress bars that "reset" progress back to 0% when the second progress bar starts.
One operation that could "want" to have multiple progress bars is @voxel51/io/import_samples when uploading media to a new location before adding samples:
Currently if the upload step happens, there is no progress bar, so the progress indicator in #101 is not particularly useful in this case as it will sit at 0% for awhile and then rapidly jump to 100% as add_samples() is a faster operation than copy_files().
An alternative to the double progress bar problem is this pattern:
Possible TODO
ProgressBar.start_msg
property invoxel51-eta
ProgressBar
infiftyone
to usestart_msg
rather than separate logging messagesctx.set_progress(label=pb.start_msg, progress=pb.progress)
Why? This would provide a bit more info to users about what is actually happening in our builtin operations. This may be especially useful if there is a builtin operation that uses multiple progress bars, in which case the naive implementation may involve two separate progress bars that "reset" progress back to 0% when the second progress bar starts.
One operation that could "want" to have multiple progress bars is
@voxel51/io/import_samples
when uploading media to a new location before adding samples:fiftyone-plugins/plugins/io/__init__.py
Line 957 in 3bde4f8
Currently if the upload step happens, there is no progress bar, so the progress indicator in #101 is not particularly useful in this case as it will sit at 0% for awhile and then rapidly jump to 100% as
add_samples()
is a faster operation thancopy_files()
.An alternative to the double progress bar problem is this pattern:
The text was updated successfully, but these errors were encountered: